WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15905
ENABLE(DATABASE) needs to be added in a few places
https://bugs.webkit.org/show_bug.cgi?id=15905
Summary
ENABLE(DATABASE) needs to be added in a few places
Justin Haygood
Reported
2007-11-08 14:44:20 PST
Some parts of the code don't protect against when database isn't enabled.
Attachments
Adds new ENABLE(DATBASE) to fix build on Qt\Windows
(1.76 KB, patch)
2007-11-08 14:44 PST
,
Justin Haygood
sam
: review-
Details
Formatted Diff
Diff
Adds new ENABLE(DATABASE) to fix build on Qt+Windows
(1.81 KB, patch)
2007-11-08 19:02 PST
,
Justin Haygood
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Justin Haygood
Comment 1
2007-11-08 14:44:59 PST
Created
attachment 17127
[details]
Adds new ENABLE(DATBASE) to fix build on Qt\Windows
Sam Weinig
Comment 2
2007-11-08 17:19:51 PST
Comment on
attachment 17127
[details]
Adds new ENABLE(DATBASE) to fix build on Qt\Windows There are some unnecessary newlines in there but otherwise r=me.
Sam Weinig
Comment 3
2007-11-08 17:21:58 PST
Comment on
attachment 17127
[details]
Adds new ENABLE(DATBASE) to fix build on Qt\Windows On second though, this needs a changelog.
Justin Haygood
Comment 4
2007-11-08 19:02:31 PST
Created
attachment 17137
[details]
Adds new ENABLE(DATABASE) to fix build on Qt+Windows 1. Adds ChangeLog 2. Addresses some concerns by bdash
Mark Rowe (bdash)
Comment 5
2007-11-08 19:10:40 PST
Comment on
attachment 17137
[details]
Adds new ENABLE(DATABASE) to fix build on Qt+Windows r=me. Please be sure to use spaces rather than tabs for indentation in your ChangeLog entry in future. I'll fix them up when I land though, no need for a new patch.
Mark Rowe (bdash)
Comment 6
2007-11-08 19:16:34 PST
Landed in
r27629
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug