Bug 15883 – REGRESSION (r27447-r27452): Incorrect window size/invalid toolbar reference using "Open Link in New Window" from context menu

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

* SUMMARY
After launching WebKit/Safari in a particular way, using the "Open Link in New Window" item from the contextual menu results in a window that is (a) not the same dimensions as the current Safari window, (b) does not have a toollbar and (c) never shows a toolbar when Cmd-L is used (error message is printed to console).

* STEPS TO REPRODUCE
1. Manually mount WebKit Nightly r27464 (e.g., double-click on the DMG icon).  Note that using bisect-builds to mount the DMG and launch WebKit nightly does not reproduce the bug.
2. Double-click on the gold Safari icon.
3. Go to URL:  http://www.google.com/
4. Right-click on "Business Solutions" (or any link on the page) and select "Open Link in New Window".

* EXPECTED RESULTS
A new window should open with the same dimensions as the current window and have a toolbar.

* ACTUAL RESULTS
A new window opens with different dimensions than the current window (it's square-ish) and does not have a toolbar.  Furthermore, using Cmd-L to display the location toolbar fails with an error message to the console:

2007-11-07 05:57:06.804 Safari[12395] ERROR: attempt to show a toolbar which is *nil*, aborting _showToolbarWithAnimation:

* REGRESSION
This is a recently WebKit nightly regression.  The bisect-builds script reports:
Works: r27434  Fails: r27464

* NOTES
Running the bisect-builds script NEVER reproduces the issue.  You must remount the nightly build images, double-click on the gold Safari icon, then run the steps to reproduce after bisect-builds starts Safari for you.

[David Kilzer (:ddkilzer)]

<rdar://problem/5584940>

[David Kilzer (:ddkilzer)]

Internal autospade narrows this down to:
Works: r27447  Fails: r27452

I suspect r27452 since this refactored window opening code in WebCore.
<http://trac.webkit.org/projects/webkit/changeset/27452>

[Tristan O'Tierney]

I've got a patch in the works.

[Tristan O'Tierney]

Looked like someone beat me to the punch.  Fixed in r27568

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Looked like someone beat me to the punch.  Fixed in r27568

You could clean up the default constructor to match WebKit formatting.  :)