RESOLVED INVALID 15860
add() could use additional speedups 
https://bugs.webkit.org/show_bug.cgi?id=15860
Summary add() could use additional speedups
Eric Seidel (no email)
Reported 2007-11-06 10:57:47 PST
add() could use additional speedups Some suggestions brought up in bug 15837 but not implemented, include: 1. Combine both types into a "type mask" using uint32_t typeMask = t1 << 3 | t2; and then check the resulting type mask instead of t1 == StringType && t2 == StringType 2. Speed up addSlowCase by passing in the typeMask and only calling toPrimative when needed 3. Speed up addSlowCase by avoiding calling toString() and using static_cast<StringImp*>(foo)->value() when possible.
Attachments
Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-11-08 23:00:09 PST
Oliver did (1) already.
Eric Seidel (no email)
Comment 2 2007-11-09 00:49:28 PST
This will actually be fixed more by bug 15884. I'm going to re-write AddNode into specialized versions to exploit at least #3. #2 becomes irrelevant.
Alexey Proskuryakov
Comment 3 2009-03-24 10:59:08 PDT
Eric, is this bug still valid? /me sounds like a broken record, yeah
Eric Seidel (no email)
Comment 4 2009-03-24 11:27:39 PDT
I don't think JSC code looks anything like this anymore. But I've not hacked on it in over a year now. :(
Note You need to log in before you can comment on or make changes to this bug.