Bug 15828 - WebKit GTK include and lib directory is in qt4-named directory
Summary: WebKit GTK include and lib directory is in qt4-named directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 523.x (Safari 3)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-04 04:41 PST by KIMURA Masaru
Modified: 2007-11-06 16:07 PST (History)
0 users

See Also:

Attachments
Use sane default install paths for the gtk port (1.04 KB, patch)
2007-11-04 05:35 PST, Christian Dywan 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KIMURA Masaru 2007-11-04 04:41:23 PST 
I found webkit ebuild for gentoo at the bugziulla[1].
Tweaking it and pushed into my personal overlay[2].
And I checked installed files' location by equery.
It said,

/usr
/usr/bin
/usr/bin/GtkLauncher
/usr/include
/usr/include/qt4
/usr/include/qt4/WebKitGtk
/usr/include/qt4/WebKitGtk/webkitgtkdefines.h
/usr/include/qt4/WebKitGtk/webkitgtkframe.h
/usr/include/qt4/WebKitGtk/webkitgtkglobal.h
/usr/include/qt4/WebKitGtk/webkitgtknetworkrequest.h
/usr/include/qt4/WebKitGtk/webkitgtkpage.h
/usr/include/qt4/WebKitGtk/webkitgtksettings.h
/usr/lib64
/usr/lib64/qt4
/usr/lib64/qt4/libWebKitGtk.prl
/usr/lib64/qt4/libWebKitGtk.so
/usr/lib64/qt4/libWebKitGtk.so.1
/usr/lib64/qt4/libWebKitGtk.so.1.0
/usr/lib64/qt4/libWebKitGtk.so.1.0.0
/usr/lib64/qt4/pkgconfig
/usr/lib64/qt4/pkgconfig/WebKitGtk.pc 

So, why gtk port is in qt-named directoy? :)

PS: And GtkLauncher is not installed by doing simply
make INSTALL_ROOT=balbla install, I realized too.

-----
[1] http://bugs.gentoo.org/show_bug.cgi?id=190347
[2] http://dev.gentoo.gr.jp/~hiyuh/cgi-bin/hgweb.cgi?file/tip/net-libs/webkit/
Comment 1 Christian Dywan 2007-11-04 05:35:52 PST 
Created attachment 17030 [details]
Use sane default install paths for the gtk port

This patch defaults to /usr/local and /usr/local/include/WebKitGtk respectively. I don't think we want to install GtkLauncher.
Comment 2 KIMURA Masaru 2007-11-04 06:29:36 PST 
At #webkit, bdash tells why gtk port was installed into that weird
location. He said http://live.gnome.org/WebKitGtk mentioned to use
--qmakearg.

I've updated my ebuild[1] (was linked my previous post) to make it
install into correct location /usr/include/WebKit and /usr/lib64
already. Because Gentoo won't install to /usr/local via portage.
But to merge this fix to upstream would be better, I think.

Note, to reproduce this weird install result is only do w/o
--qmakearg which is mentioned at http://live.gnome.org/WebKitGtk.
Comment 3 Holger Freyther 2007-11-04 12:44:05 PST 
(In reply to comment #1)
> Created an attachment (id=17030) [edit]
> Use sane default install paths for the gtk port
> 
> This patch defaults to /usr/local and /usr/local/include/WebKitGtk
> respectively. I don't think we want to install GtkLauncher.

The patch should get a positive review. Yes we should not install the GtkLauncher as it is using rpath for linking because we/I currently don't want it to be installed.
Comment 4 Darin Adler 2007-11-06 07:42:33 PST 
Comment on attachment 17030 [details]
Use sane default install paths for the gtk port

r=me
Comment 5 Mark Rowe (bdash) 2007-11-06 16:07:40 PST 
Landed in r27492.