NEW 15788
Eliminate ContextMenuClient::searchWithGoogle() 
https://bugs.webkit.org/show_bug.cgi?id=15788
Summary Eliminate ContextMenuClient::searchWithGoogle()
Alp Toker
Reported 2007-11-01 16:38:59 PDT
(1) Current builds of WebKit will probably be in use decades from now. Search engines come and go. Any search product that is hard-coded into the API will soon become an anachronism. (2) Seeing a competitor's name in the code base can be a turn off for search engine vendors looking to contribute to or embed WebKit. (3) Google's search product is not the first choice in some parts of the world. Given these points, ContextMenuClient::searchWithGoogle() should probably be axed. If Google is paying for the product placement, it should probably be implemented at a higher level in Safari, not in ContextMenuClient.
Attachments
Add attachment proposed patch, testcase, etc.
Ryan Leavengood
Comment 1 2007-11-16 23:00:49 PST
I was thinking the same thing recently when working on my Haiku port. I use Google a lot, but embedding that name in an API probably isn't wise. One thing I was wondering today is if anyone is working on OpenSearch support in WebKit? This is how the Firefox "Search Engines" are implemented, and IE7 also supports this. See http://www.opensearch.org/Home I think this would be a useful addition to WebKit and having a nice API for it would allow all platforms to easily use it in their browsers. Then this searchWithGoogle could be replaced with searchWithEngine or similar. If no one else works on it, I probably will, once my Haiku port is in decent shape.
David Kilzer (:ddkilzer)
Comment 2 2007-11-17 11:14:34 PST
(In reply to comment #1) > One thing I was wondering today is if anyone is working on OpenSearch support > in WebKit? This is how the Firefox "Search Engines" are implemented, and IE7 > also supports this. See http://www.opensearch.org/Home > > I think this would be a useful addition to WebKit and having a nice API for it > would allow all platforms to easily use it in their browsers. Then this > searchWithGoogle could be replaced with searchWithEngine or similar. Please file a new bug for this feature. Thanks!
David Kilzer (:ddkilzer)
Comment 3 2007-11-17 21:11:51 PST
(In reply to comment #2) > (In reply to comment #1) > > One thing I was wondering today is if anyone is working on OpenSearch support > > in WebKit? This is how the Firefox "Search Engines" are implemented, and IE7 > > also supports this. See http://www.opensearch.org/Home > > > > I think this would be a useful addition to WebKit and having a nice API for it > > would allow all platforms to easily use it in their browsers. Then this > > searchWithGoogle could be replaced with searchWithEngine or similar. > > Please file a new bug for this feature. Thanks! Bug 16030
Note You need to log in before you can comment on or make changes to this bug.