Bug 15781 – REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle a marked range that covers half of a composed character sequence)

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Oliver Hunt]

Create a new message in mail. Select the Devanagari keyboard. Begin typing. Characters that should form ligatures are rendered separately not in combination. For example, the key sequence K D Shift-comma should produce a single glyph (see picture)

This problem only seems to happen with text typed directly into mail. Create the text in Text Edit (which works correctly) and copy into mail. The text will render correctly.

The same problem happens with Gujarati, but not with Tamil or Arabic.

[Oliver Hunt]

This problem is like not being able to type the letter "A" in English. Nominating for Intl BRB review.

23/09/07 1:29 PM Darin Adler:
I believe this problem occurs because of the behavior of the methods that the Devanagari input method uses to read from the document, rather than the ones it uses to write. The WebKit view has a system where it only returns part of the document to the input method which is probably causing the problem.

23/09/07 1:40 PM Darin Adler:
That theory was wrong.

The real bug here is that the text insertion command, told to select the inserted text, fails to. The proximate cause of this is that appliedEditing is not called in TypingCommand::typingAddedToOpenCommand because m_applyEditing is false.

23/09/07 1:51 PM Darin Adler:
The Devanagari input method marks only one character from a composed character pair, and the code can't handle that.

23/09/07 2:10 PM Darin Adler:
Fixing this requires changing our input method handling so that we never try to treat the marked text range (called the "composition" in our cross-platform code and on Windows) as a selection.

Doing that requires teaching the editing machinery how to handle these non-selection ranges.

23/09/07 2:44 PM Darin Adler:
I worked out a fix, not using selection for manipulating the marked range, and it seems to be working. However it's a pretty risky change -- I don't know what effect it will have on other input methods -- and I also don't have undo implemented yet. I also need to run the regression tests.

23/09/07 4:05 PM Darin Adler:
Ollie, I attached my patch, which is a start at resolving this. The primary remaining issue is fitting this into the undo machinery. It also affects the results of some of the regression tests because of different delegate calls.

[Oliver Hunt]

Alexey, can you look at this? I'll attach darin's partial fix

[Oliver Hunt]

Created attachment 16972 [details]
Initial patch to allow sub-character composition ranges

[Alexey Proskuryakov]

See also: bug 15790.

[Alexey Proskuryakov]

Another example: typing "mfm" with Devanagari-Qwerty layout.

[Maciej Stachowiak]

<rdar://problem/4086750>

[Alexey Proskuryakov]

Created attachment 17266 [details]
hackish fix

[Justin Garcia]

Comment on attachment 17266 [details]
hackish fix

+        However, this is not entirely new for them, as Roman accents are typed iin a similar manner.

Typo.  

Looks like an OK temporary fix to me.

[Alexey Proskuryakov]

Committed revision 27809.