Bug 15767 – Text decorations do not respect "visibility" property

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Andreas Neumann]

In the example map of Austria, if one toggles the visibility of the layer "Cities" the underline of the text "Wien", set with text-decoration:underline remains visible while the rest of the text disappears. For correct behavior, the visibility of the underline text-decoration should follow the rest of the text.

The layer toggling is achieved by setting the "visibility" attribute.

Thank you for having a look at this issue.

[Eric Seidel (no email)]

Ok, I have a reduction.

[Eric Seidel (no email)]

Created attachment 17045 [details]
test case

Thanks for the bug!

[Eric Seidel (no email)]

This is only a nightly problem as Safari 3 did not have text-decoration support for SVG text.

[Rob Buis]

Created attachment 17683 [details]
First attempt

This should fix it :) Testcase is basically the reduced testcase.
Cheers,

Rob.

[Nikolas Zimmermann]

(In reply to comment #4)
> Created an attachment (id=17683) [edit]
> First attempt
> 
> This should fix it :) Testcase is basically the reduced testcase.
> Cheers,
> 
> Rob.
> 
Hey Rob,

nice to see you back hacking :-)
the patch itself is correct - though there's a faster way to do that.

Remove the check again, and also remove it from SVGInlineTextBox::paintCharacters.
In SVGRootInlineBox:525 (SVGRootInlineBoxWalker, chunkPortionCallback function)
it should be checked once wheter visiblity is visible or hidden - and not call the
several paintDecoration functions at all.

I forgot about this bug :-)

Greetings,
Niko

[Darin Adler]

Comment on attachment 17683 [details]
First attempt

Looks fine, r=me.

Extra space before the ")" character.

[Rob Buis]

Landed in r28363.