compiler warning

[David Carson]

Some compilers give a warning for the following function:

inline bool JSValue::isNumber() const
{
    return JSImmediate::isNumber(this) || !JSImmediate::isImmediate(this) && asCell()->isNumber();
}

"warning: suggest parentheses around && within ||"

This file is compiled into a lot of the JSCore files and the warning is seen for every file.

[David Carson]

Created attachment 16948 [details]
patch

insert suggested braces, also makes it easier to read.

[Darin Adler]

Comment on attachment 16948 [details]
patch

Parentheses look fine. But not the spaces within the parentheses! We don't use spaces there in our expressions.

[Darin Adler]

Committed revision 27381.