Bug 15763 - [GTK] Enter key does not take to the link highlighted.
Summary: [GTK] Enter key does not take to the link highlighted.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://altavista.com
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-10-30 04:36 PDT by Naiem
Modified: 2007-11-20 13:48 PST (History)
1 user (show)

See Also:

Attachments
Gdk_return was not being handled, so added it (18.56 KB, patch)
2007-11-18 20:34 PST, Naiem 		alp: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naiem 2007-10-30 04:36:52 PDT 
Hi,
I am working in linux box and do not have mouse to do selection of links in a webpage.

Prior information : 
I have applied the patch in bug 15653 and made "return true" in ChromeClient::tabsToLinks() to enable the navigation mode using tabs.

When I run the GtkLauncher, test application present in WebkitTools/Gtklauncher, following is the issue I have faced.
Using Tab key I can scroll between the links,but "Enter key" does not take to the highlighted link.
Comment 1 Alp Toker 2007-11-18 09:41:43 PST 
Yep, this still needs to be implemented, patches welcome. Please don't mark bugs like this as "Major".
Comment 2 Naiem 2007-11-18 20:34:48 PST 
Created attachment 17373 [details]
Gdk_return was not being handled, so added it

Gdk_Return key press event was not being handled.
Comment 3 Alp Toker 2007-11-20 13:44:22 PST 
Comment on attachment 17373 [details]
Gdk_return was not being handled, so added it

Thanks, please provide a patch and a ChangeLog entry next time.
Comment 4 Alp Toker 2007-11-20 13:48:30 PST 
Fixed in r27932. It would be nice to clean up these keycodes with a more formal approach some time.