Rename all protector variables that should be called `protectedThis` Per the new style guideline implemented in https://bugs.webkit.org/show_bug.cgi?id=157591 this is the most straightforward upgrade to existing code, as "protectedThis" protectors are almost impossible to be confused with something that is not a protector object.
Created attachment 278732 [details] Patch Not bothering with ChangeLog or running EWS quite yet, as there's still discussion in 157591 as to whether we're going forward with this new style guideline.
Created attachment 278845 [details] Patch
Attachment 278845 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 278849 [details] Patch
Attachment 278849 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 278852 [details] Patch
Attachment 278852 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 278854 [details] Patch
Attachment 278854 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:611: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:741: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:777: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:783: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:911: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1267: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:125: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:144: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 8 in 92 files If any of these errors are false positives, please file a bug against check-webkit-style.
This version of the patch should be good - Only MacWK1 EWS hasn't passed yet, and that's because of a problem in the tree unrelated to this patch.
Comment on attachment 278854 [details] Patch Clearing flags on attachment: 278854 Committed r200895: <http://trac.webkit.org/changeset/200895>
All reviewed patches have been landed. Closing bug.