WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15746
#ifndef ASSERT_DISABLED is no good!
https://bugs.webkit.org/show_bug.cgi?id=15746
Summary
#ifndef ASSERT_DISABLED is no good!
Geoffrey Garen
Reported
2007-10-28 22:38:02 PDT
ASSERT_DISABLED is always defined in Mac OS X builds, so code that relies on #ifndef ASSERT_DISABLED to do debugging won't work. We have code like this in, for example, HashTable.h
Attachments
Patch
(2.84 KB, patch)
2007-10-28 22:46 PDT
,
Geoffrey Garen
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2007-10-28 22:46:34 PDT
Created
attachment 16933
[details]
Patch Mac debug and release builds succeed.
Geoffrey Garen
Comment 2
2007-10-28 23:04:55 PDT
Committed revision 27211.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug