Bug 15744 - Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to the AST transform
Summary: Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 14868
  Show dependency tree / graph
 
Reported: 2007-10-28 21:34 PDT by Geoffrey Garen
Modified: 2007-10-28 22:43 PDT (History)
0 users

See Also:

Attachments
Patch (12.49 KB, patch)
2007-10-28 21:34 PDT, Geoffrey Garen 		darin: review-
Details | Formatted Diff | Diff
Patch2 (13.32 KB, patch)
2007-10-28 22:24 PDT, Geoffrey Garen 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2007-10-28 21:34:35 PDT 
Subtask of bug 14868.
Comment 1 Geoffrey Garen 2007-10-28 21:34:57 PDT 
Created attachment 16931 [details]
Patch
Comment 2 Darin Adler 2007-10-28 22:03:09 PDT 
Comment on attachment 16931 [details]
Patch

+JSValue* LocalVarDeleteNode::evaluate(ExecState* exec)

Unused parameter. Will warn when you merge with my settings.

+        , ident(ident)
+        , args(args.release())

These should both pass PlacementNewAdopt. See my recent patch for details.

Otherwise great!
Comment 3 Geoffrey Garen 2007-10-28 22:24:49 PDT 
Created attachment 16932 [details]
Patch2

Factored ASSERT code out into canSkipLookup. Removed unused parameter.
Comment 4 Geoffrey Garen 2007-10-28 22:25:06 PDT 
Also used the right initializers.
Comment 5 Darin Adler 2007-10-28 22:31:31 PDT 
Comment on attachment 16932 [details]
Patch2

I'm worried about warnings in release builds due to the unused function.

r=me
Comment 6 Geoffrey Garen 2007-10-28 22:43:43 PDT 
Committed revision 27210, with an #if !ASSERT_DISABLED.