Bug 15738 – a few SunSpider script improvements

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Darin Adler]

I made a couple script improvements, to get ready for a mode where we can set a baseline and do automatic comparisons with the last run.

[Darin Adler]

Created attachment 16920 [details]
patch

[Adam Roben (:aroben)]

Comment on attachment 16920 [details]
patch

+system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f", "resources/sunspider-analyze-results.js");

You could remove the quotes from around $jsShellPath while you're at it.

+                $foundOutput = 0;
+		$foundStart = 1;
+                $result = "[{\n";

Looks like you've got some tabs here.

 	} else {
-	    if (/^[}][]]$/) {
+            print;

Did you intend to insert this print statement?

+                s/;*$//;


Do we really expect to have multiple semi-colons here?

r=me

[Darin Adler]

(In reply to comment #2)
> +system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f",
> "resources/sunspider-analyze-results.js");
> 
> You could remove the quotes from around $jsShellPath while you're at it.

Done.

> +                $foundOutput = 0;
> +               $foundStart = 1;
> +                $result = "[{\n";
> 
> Looks like you've got some tabs here.

Hmm, the pre-existing file seems to have some tabs. Removed

>         } else {
> -           if (/^[}][]]$/) {
> +            print;
> 
> Did you intend to insert this print statement?

Oops!

> +                s/;*$//;
> 
> 
> Do we really expect to have multiple semi-colons here?

I'll switch to ? instead of *.