Bug 15725 - [GTK] WebCore.pro header dependencies are incorrect
Summary: [GTK] WebCore.pro header dependencies are incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-10-27 20:37 PDT by Alp Toker
Modified: 2007-10-29 15:40 PDT (History)
1 user (show)

See Also:


Attachments
Fix header dependencies in the build system (1.77 KB, patch)
2007-10-27 20:38 PDT, Alp Toker
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-10-27 20:37:34 PDT
The list of header directories is incomplete, and there are still some 'gdk' paths from before the port was renamed.

This leads to failed builds and having to "make clean" quite often.
Comment 1 Alp Toker 2007-10-27 20:38:30 PDT
Created attachment 16907 [details]
 Fix header dependencies in the build system


INCLUDEPATH and DEPENDPATH are now up to date.
---
 WebCore/WebCore.pro |   37 ++++++++++++++++++++++++++-----------
 1 files changed, 26 insertions(+), 11 deletions(-)
Comment 2 Alp Toker 2007-10-27 21:22:30 PDT
(In reply to comment #1)
> Created an attachment (id=16907) [edit]
>  Fix header dependencies in the build system
> 
> 
> INCLUDEPATH and DEPENDPATH are now up to date.
> ---
>  WebCore/WebCore.pro |   37 ++++++++++++++++++++++++++-----------
>  1 files changed, 26 insertions(+), 11 deletions(-)
> 

Addendum:

diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro
index 271f296..7f5c0ff 100644
--- a/WebCore/WebCore.pro
+++ b/WebCore/WebCore.pro
@@ -131,6 +131,7 @@ INCLUDEPATH +=  $$PWD \
                 $$PWD/.. \
                 $$PWD/../JavaScriptCore/kjs \
                 $$PWD/../JavaScriptCore/bindings \
+                $$PWD/../JavaScriptCore/wtf \
                 $$PWD/platform \
                 $$PWD/platform/network \
                 $$PWD/platform/graphics \
Comment 3 Adam Roben (:aroben) 2007-10-27 22:17:21 PDT
Comment on attachment 16907 [details]
 Fix header dependencies in the build system

r=me
Comment 4 Mark Rowe (bdash) 2007-10-28 03:42:24 PDT
Alp, does this completely fix the problem or does it just improve the situation?
Comment 5 Alp Toker 2007-10-28 11:18:51 PDT
Much improved, but I ended up with a crashy build and had to do a "make clean" earlier today, possibly following recent JSCore changes.
Comment 6 Alp Toker 2007-10-29 15:40:02 PDT
Landed in r27234. Closing this bug, though not convinced all possible dependency issues are solved.