Bug 15722 - [GTK] Refactor gtk/RenderThemeGtk and implement a few more methods
Summary: [GTK] Refactor gtk/RenderThemeGtk and implement a few more methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P3 Enhancement
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-10-27 02:35 PDT by Jan Alonzo
Modified: 2007-10-27 03:52 PDT (History)
0 users

See Also:


Attachments
RenderThemeGtk refactor patch (9.88 KB, patch)
2007-10-27 02:36 PDT, Jan Alonzo
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2007-10-27 02:35:21 PDT
The attached patch refactors RenderThemeGtk and tries to make the implementation consistent with the Qt and Safari ports. Some of the implementation are copied and pasted from Qt or Safari. 

Comments welcome.
Comment 1 Jan Alonzo 2007-10-27 02:36:11 PDT
Created attachment 16898 [details]
RenderThemeGtk refactor patch
Comment 2 Alp Toker 2007-10-27 03:52:16 PDT
Landed in r27147 with one brace position coding style fix and some fixes to the ChangeLog entry (should use spaces, not tabs, and provide the bug URL).