Bug 15668 - build-webkit (and other build scripts) should hide setenv commands by default
Summary: build-webkit (and other build scripts) should hide setenv commands by default
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-24 12:18 PDT by Eric Seidel (no email)
Modified: 2022-12-06 14:19 PST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-24 12:18:13 PDT
build-webkit (and other build scripts) should hit setenv commands by default

*most* of the XCode build output is useless setenv commands (duplicated for each call to gcc).  build-webkit should grep out this setenv output in a default "not quite so loud" mode. :)

I would do it, but I don't see a slick way of calling system and piping the output through grep. I think the way we'll have to do it is two open2() calls which pipe the output of xcodebuild to grep and the on to STDERR/STDOUT.
Comment 1 Mark Rowe (bdash) 2007-10-24 13:20:04 PDT
The setenv commands are not duplicated for each call to gcc as you claim.  I believe they're printed once for each non-compile phase, or something to that effect.  If you implement this, please make it easy to disable this filtering as I often use build-webkit to check the values of the Xcode configuration variables, rather than make which always filters them out and is not easily configurable like build-webkit.
Comment 2 David Kilzer (:ddkilzer) 2007-10-24 19:24:08 PDT
What's wrong with doing this?

build-webkit | grep -v setenv
Comment 3 Ahmad Saleem 2022-12-06 14:08:00 PST
@ap - This enhancement is still applicable or we can close this? Thanks!
Comment 4 Alexey Proskuryakov 2022-12-06 14:19:10 PST
People who want this behavior typically pipe through filter-build-webkit. 

And yes, as Mark pointed out, these are not duplicated, and are in fact often useful.

It's the typical "make it quiet except when I actually want to see everything" problem, and I think that the best way to resolve this is by sticking to what Xcode does by default, and letting people use filter-build-webkit when desired.