Bug 15663 - update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
Summary: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-24 07:45 PDT by Alexey Proskuryakov
Modified: 2008-01-04 09:25 PST (History)
0 users

See Also:

Attachments
patch with changelog (4.31 KB, patch)
2008-01-03 10:15 PST, Adam Roben (:aroben) 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-10-24 07:45:35 PDT 
update-webkit-auxiliary-libs checks HTTP response headers to decide whether to update WebKitAuxiliaryLibrary.zip - but apparently there are several servers behind http://developer.apple.com, and the date of this file is slightly different on each:

$ curl -s -I http://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip | grep Last-Modified
Last-Modified: Tue, 12 Jun 2007 20:48:03 GMT
$ curl -s -I http://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip | grep Last-Modified
Last-Modified: Tue, 12 Jun 2007 20:47:59 GMT
Comment 1 Adam Roben (:aroben) 2008-01-03 10:15:40 PST 
Created attachment 18252 [details]
patch with changelog
Comment 2 Mark Rowe (bdash) 2008-01-03 10:17:33 PST 
Comment on attachment 18252 [details]
patch with changelog

r=me
Comment 3 Alexey Proskuryakov 2008-01-04 09:25:08 PST 
Committed in <http://trac.webkit.org/projects/webkit/changeset/29127>, with a follow-up in <http://trac.webkit.org/projects/webkit/changeset/29129>.