Bug 15646 – [GTK] caretBlinkFrequency is hard-coded in Frame.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alp Toker]

WebCore/page/Frame.cpp:

static const double caretBlinkFrequency = 0.5;

On GTK+ at least, this is configurable. It can even change while the application is running, so we need to abstract this setting. It does not, however, need to be configurable in any public API.

From gtktextview.c in GTK+:

static gboolean
cursor_blinks (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gboolean blink;

#ifdef DEBUG_VALIDATION_AND_SCROLLING
  return FALSE;
#endif
  if (gtk_debug_flags & GTK_DEBUG_UPDATES)
    return FALSE;

  g_object_get (settings, "gtk-cursor-blink", &blink, NULL);

  if (!blink)
    return FALSE;

  if (text_view->editable)
    {
      GtkTextMark *insert;
      GtkTextIter iter;
      
      insert = gtk_text_buffer_get_insert (get_buffer (text_view));
      gtk_text_buffer_get_iter_at_mark (get_buffer (text_view), &iter, insert);
      
      if (gtk_text_iter_editable (&iter, text_view->editable))
	return blink;
    }

  return FALSE;
}

static gint
get_cursor_time (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gint time;

  g_object_get (settings, "gtk-cursor-blink-time", &time, NULL);

  return time;
}

static gint
get_cursor_blink_timeout (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gint time;

  g_object_get (settings, "gtk-cursor-blink-timeout", &time, NULL);

  return time;
}

[Alp Toker]

Any suggestions where a good place to abstract this would be?

[Alp Toker]

Created attachment 16905 [details]
[PATCH] Fix header dependencies in the build system


INCLUDEPATH and DEPENDPATH are now up to date.
---
 WebCore/WebCore.pro |   37 ++++++++++++++++++++++++++-----------
 1 files changed, 26 insertions(+), 11 deletions(-)

[Alp Toker]

Created attachment 16906 [details]
[PATCH] http://bugs.webkit.org/show_bug.cgi?id=15646

[GTK] caretBlinkFrequency is hard-coded in Frame.cpp

Abstract caretBlinkFrequency to RenderTheme.
---
 WebCore/page/Frame.cpp                  |    4 +---
 WebCore/platform/gtk/RenderThemeGtk.cpp |   23 +++++++++++++++++++++++
 WebCore/platform/gtk/RenderThemeGtk.h   |    3 +++
 WebCore/rendering/RenderTheme.h         |    2 ++
 4 files changed, 29 insertions(+), 3 deletions(-)

[Alp Toker]

Comment on attachment 16905 [details]
[PATCH] Fix header dependencies in the build system

Not for review. (Was experimenting with a modified git-send-bugzilla.)

[Adam Roben (:aroben)]

Comment on attachment 16906 [details]
[PATCH] http://bugs.webkit.org/show_bug.cgi?id=15646

r=me

[Alp Toker]

Landed in r27169.