Bug 15632 - js1_5/Array/array-001.js test failing
Summary: js1_5/Array/array-001.js test failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Major
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-22 16:36 PDT by Darin Adler
Modified: 2007-10-22 17:57 PDT (History)
1 user (show)

See Also:


Attachments
patch with change log and tests (9.94 KB, patch)
2007-10-22 16:36 PDT, Darin Adler
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-10-22 16:36:03 PDT
I figured out why this test is failing, it's a problem with fractional array indices. Not sure why this didn't fail when I did my pre-submission tests.

I have a fix almost done.
Comment 1 Darin Adler 2007-10-22 16:36:55 PDT
Created attachment 16811 [details]
patch with change log and tests
Comment 2 Geoffrey Garen 2007-10-22 16:43:23 PDT
Comment on attachment 16811 [details]
patch with change log and tests

r=me
Comment 3 Darin Adler 2007-10-22 16:47:11 PDT
Committed revision 26899.
Comment 4 Eric Seidel (no email) 2007-10-22 16:48:56 PDT
I'm not sure the float/double variants are actually any benefit now that this has to do the blind-assignment and equality check.  I bet the compiler was previously optimizing out the float to double back to int conversion into just a float to int conversion... but we'd have to look at the assembler to be sure.
Comment 5 Darin Adler 2007-10-22 17:57:52 PDT
(In reply to comment #4)
> I'm not sure the float/double variants are actually any benefit now that this
> has to do the blind-assignment and equality check.  I bet the compiler was
> previously optimizing out the float to double back to int conversion into just
> a float to int conversion... but we'd have to look at the assembler to be sure.

I'm almost sure it was not. I saw conversion to float in the assembler.

But please investigate!