WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15605
add crypto tests to sunspider
https://bugs.webkit.org/show_bug.cgi?id=15605
Summary
add crypto tests to sunspider
Maciej Stachowiak
Reported
2007-10-21 19:59:38 PDT
Crypto code tends to be slower than people would like in JavaScript. SunSpider could use some crypto test cases.
Attachments
crypto tests: AES, MD5 and SHA-1
(34.78 KB, patch)
2007-10-21 20:00 PDT
,
Maciej Stachowiak
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2007-10-21 20:00:35 PDT
Created
attachment 16775
[details]
crypto tests: AES, MD5 and SHA-1
Eric Seidel (no email)
Comment 2
2007-10-21 20:22:14 PDT
Comment on
attachment 16775
[details]
crypto tests: AES, MD5 and SHA-1 Looks fine. As I noted in IRC, the only issues I could foresee are 1. polluting the global object (and thus putting memory pressure on later tests) and 2. none of these test check correctness (to make sure they don't break in the future). A simple comparison of original plain and decrypted text in aes, and comparison with known-good hash values for md5 and sha1. But none of these are major issues, and you should feel free to address them later.
Mark Rowe (bdash)
Comment 3
2007-10-22 00:09:41 PDT
This was landed in
r26858
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug