Bug 15605 - add crypto tests to sunspider
Summary: add crypto tests to sunspider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P3 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-21 19:59 PDT by Maciej Stachowiak
Modified: 2007-10-22 00:09 PDT (History)
0 users

See Also:

Attachments
crypto tests: AES, MD5 and SHA-1 (34.78 KB, patch)
2007-10-21 20:00 PDT, Maciej Stachowiak 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-10-21 19:59:38 PDT 
Crypto code tends to be slower than people would like in JavaScript. SunSpider could use some crypto test cases.
Comment 1 Maciej Stachowiak 2007-10-21 20:00:35 PDT 
Created attachment 16775 [details]
crypto tests: AES, MD5 and SHA-1
Comment 2 Eric Seidel (no email) 2007-10-21 20:22:14 PDT 
Comment on attachment 16775 [details]
crypto tests: AES, MD5 and SHA-1

Looks fine.  As I noted in IRC, the only issues I could foresee are 1.  polluting the global object (and thus putting memory pressure on later tests) and 2. none of these test check correctness (to make sure they don't break in the future).  A simple comparison of original plain and decrypted text in aes, and comparison with known-good hash values for md5 and sha1.  But none of these are major issues, and you should feel free to address them later.
Comment 3 Mark Rowe (bdash) 2007-10-22 00:09:41 PDT 
This was landed in r26858.