Bug 15583 - Sunspider needs better argument handling
Summary: Sunspider needs better argument handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-20 18:31 PDT by Eric Seidel (no email)
Modified: 2007-10-20 19:55 PDT (History)
0 users

See Also:

Attachments
the patch (11.03 KB, patch)
2007-10-20 18:32 PDT, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
even better patch (18.70 KB, patch)
2007-10-20 19:26 PDT, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-20 18:31:53 PDT 
Sunspider needs better argument handling

The attached patch does just that! :)
Comment 1 Eric Seidel (no email) 2007-10-20 18:32:19 PDT 
Created attachment 16750 [details]
the patch
Comment 2 Darin Adler 2007-10-20 18:53:39 PDT 
Comment on attachment 16750 [details]
the patch

r=me
Comment 3 Eric Seidel (no email) 2007-10-20 19:26:51 PDT 
Created attachment 16753 [details]
even better patch

Mark Rowe pointed out that we were duplicating the testkjs building code, so I fixed that.  I also cleaned up some other (broken) building code in other files.
Comment 4 Darin Adler 2007-10-20 19:44:46 PDT 
Comment on attachment 16753 [details]
even better patch

All looks good. r=me
Comment 5 Eric Seidel (no email) 2007-10-20 19:55:38 PDT 
r26838