X11 has a Window type which causes conflicts when building with #include <X11/Xlib.h>. To resolve this, we must use KJS::Window everywhere, rather than just Window, and avoid "using KJS::Window;". The attached patch fixes this, so that this conflict is resolved.
Created attachment 16731 [details] Patch to use KJS::Window instead of just Window where appropriate
Comment on attachment 16731 [details] Patch to use KJS::Window instead of just Window where appropriate I don't think the references to Window that are inside the KJS namespace need to change. So that means we don't need any changes to kjs_window.h, JSXMLHttpRequest.cpp, or kjs_binding.cpp. Could you try tossing the changes to those files? Otherwise this looks great.
Created attachment 16732 [details] Updated patch with darin's suggestions
Comment on attachment 16732 [details] Updated patch with darin's suggestions Looks good. Needs ChangeLog.
Created attachment 16733 [details] Updated patch with ChangeLog entry
Landed in r26816. Thanks for the patch! One minor nit -- you had used tabs in your ChangeLog entry so I had to tweak it before landing.