Bug 15536 - need to cache missing glyph so we're not slow on pages that show missing glyphs
Summary: need to cache missing glyph so we're not slow on pages that show missing glyphs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-16 16:56 PDT by Darin Adler
Modified: 2007-10-16 22:02 PDT (History)
0 users

See Also:


Attachments
patch to cache missing glyphs too (7.27 KB, patch)
2007-10-16 16:59 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
patch to cache missing glyphs too (Windows fixed now) (7.16 KB, patch)
2007-10-16 18:01 PDT, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-10-16 16:56:39 PDT
Right now the cache can't handle caching the missing glyph.
Comment 1 Darin Adler 2007-10-16 16:59:54 PDT
Created attachment 16689 [details]
patch to cache missing glyphs too
Comment 2 mitz 2007-10-16 17:32:27 PDT
Comment on attachment 16689 [details]
patch to cache missing glyphs too

+        glyphRecord = (ATSLayoutRecord *)((char *)glyphRecord + wkGetGlyphVectorRecordSize(glyphVector));

Looks like this was copied from Mac by mistake.
Comment 3 Darin Adler 2007-10-16 18:01:02 PDT
Created attachment 16690 [details]
patch to cache missing glyphs too (Windows fixed now)
Comment 4 mitz 2007-10-16 18:11:34 PDT
Comment on attachment 16690 [details]
patch to cache missing glyphs too (Windows fixed now)

r=me
Comment 5 Darin Adler 2007-10-16 22:02:29 PDT
Committed revision 26696.