RESOLVED FIXED 15531
integrate changes from PCRE 6.4 to 6.5 
https://bugs.webkit.org/show_bug.cgi?id=15531
Summary integrate changes from PCRE 6.4 to 6.5
Darin Adler
Reported 2007-10-16 07:48:03 PDT
I've got PCRE 6.5 merged in. We should merge all the way up to the latest PCRE.
Attachments
merge of changes from 6.4 to 6.5 (772.67 KB, patch)
2007-10-16 07:49 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-10-16 07:49:12 PDT
Created attachment 16684 [details] merge of changes from 6.4 to 6.5
Geoffrey Garen
Comment 2 2007-10-16 11:50:46 PDT
Looks good, but it's pretty hard to tell if things are right just by code inspection. r=me if the JS and layout tests pass. One nit: 87 /* Win32 uses DLL by default; it needs special stuff for exported functions. */ 88 89 #ifdef _WIN32 90 # ifdef PCRE_DEFINITION 91 # ifdef DLL_EXPORT 92 # define PCRE_DATA_SCOPE __declspec(dllexport) 93 # endif 94 # else 95 # ifndef PCRE_STATIC 96 # define PCRE_DATA_SCOPE extern __declspec(dllimport) 97 # endif 98 # endif 99 #endif 100 I don't think we want to export PCRE functions from the WebKit DLL on Windows, do we?
Darin Adler
Comment 3 2007-10-16 14:53:11 PDT
(In reply to comment #2) > I don't think we want to export PCRE functions from the WebKit DLL on Windows, > do we? PCRE_STATIC should be set. I'll make sure to do that.
Darin Adler
Comment 4 2007-10-16 22:49:19 PDT
Committed revision 26697.
Note You need to log in before you can comment on or make changes to this bug.