WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15514
<clipPath> with <use> not respected
https://bugs.webkit.org/show_bug.cgi?id=15514
Summary
<clipPath> with <use> not respected
Eric Seidel (no email)
Reported
2007-10-14 16:06:32 PDT
SVG displays extra black transparent square
http://www.carto.net/neumann/cartography/papermaps/japan.svgz
not sure why. needs reduction.
Attachments
test case
(369 bytes, image/svg+xml)
2007-10-15 00:11 PDT
,
Eric Seidel (no email)
no flags
Details
First attempt
(47.63 KB, patch)
2007-12-25 06:18 PST
,
Rob Buis
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2007-10-14 16:07:22 PDT
These have the same issue:
http://www.carto.net/neumann/cartography/papermaps/korea.svgz
http://www.carto.net/neumann/cartography/papermaps/china.svgz
Eric Seidel (no email)
Comment 2
2007-10-15 00:10:36 PDT
Turn out this is a problem with our <clipPath> and <use> support.
Eric Seidel (no email)
Comment 3
2007-10-15 00:11:01 PDT
Created
attachment 16675
[details]
test case
Rob Buis
Comment 4
2007-12-25 06:18:00 PST
Created
attachment 18107
[details]
First attempt I fixed the bug but also tried to look at the functionality of using <use> from a clip path a bit more, particularly the part that describes indirect references are disallowed. The second testcase tests this, Opera and Firefox do allow that clip path, so either I am misunderstanding the spec or they are wrong. Cheers, Rob.
Eric Seidel (no email)
Comment 5
2007-12-25 15:00:24 PST
You are the most wonderful bug sniper ever! All these old little bugs slowly getting picked off by Rob... one at a time... :) I'll actually review your patch after all the xmas celebration (assuming no one else beats me to it).
Eric Seidel (no email)
Comment 6
2007-12-25 20:04:40 PST
Comment on
attachment 18107
[details]
First attempt A few comments. 1. You might mention the section of the spec, or even the text, indicating the direct reference requirement: 14.3.5 Establishing a new clipping path A 'clipPath' element can contain 'path' elements, 'text' elements, basic shapes (such as 'circle') or a 'use' element. If a 'use' element is a child of a 'clipPath' element, it must directly reference 'path', 'text' or basic shape elements. Single line ifs (including those with comments) do no use { } according to the webkit style guidelines. Otherwise looks great. I assume that both test cases show 100x100 green rects on TOT? r=me, assuming you fix the spec comment and style issue.
Rob Buis
Comment 7
2007-12-26 00:41:17 PST
Landed in
r28991
.
Eric Seidel (no email)
Comment 8
2007-12-27 01:29:05 PST
***
Bug 16557
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug