Bug 15480 – SVG requiredFeatures broken

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[jay]

requiredFeatures combined with switch provides a relatively easy way for the author to create workarounds.

but not if it isn't supported....

[jay]

Created attachment 16644 [details]
test for static support

[jay]

the attachment renders as "RDF"

however as static requires all features to be supported and font is not supported the result should be "3"
as per mozilla... 
opera does support font and displays the glyph for background of the new SVG logo

[Eric Seidel (no email)]

Interesting.  This shows two bugs.  1.  We shouldn't be claiming to support "static" when we don't support fonts.  2.  We are rendering the contents of <title> elements, which we should not do.

[Eric Seidel (no email)]

Ah!  We're not rendering <title> elements, it's being used by a tref.  So the only bug here is that hasFeature reports too many features for WebKit (since we don't support SVG fonts).

[Eric Seidel (no email)]

Created attachment 17986 [details]
Patch to make our feature strings match reality

This patch should make our feature strings match reality.  I've not yet run the layout tests to get an updated patch for those yet.

[Eric Seidel (no email)]

Of course whenever Niko's font patch lands, we'll have to re-enable a bunch of these strings again!

[Eric Seidel (no email)]

Created attachment 18004 [details]
Stop claiming to support SVG feature strings we don't

 LayoutTests/ChangeLog                              |   16 +++++++
 .../W3C-SVG-1.1/struct-cond-03-t-expected.checksum |    2 +-
 .../svg/W3C-SVG-1.1/struct-cond-03-t-expected.png  |  Bin 12813 -> 7287 bytes
 .../svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt  |   10 +----
 .../struct-image-02-b-expected.checksum            |    2 +-
 .../svg/W3C-SVG-1.1/struct-image-02-b-expected.png |  Bin 50516 -> 50517 bytes
 .../svg/W3C-SVG-1.1/struct-image-02-b-expected.txt |    9 ++--
 LayoutTests/svg/custom/svg-features-expected.txt   |   26 ++++++------
 WebCore/ChangeLog                                  |   11 +++++
 WebCore/dom/DOMImplementation.cpp                  |   44 +++++++++++--------
 10 files changed, 73 insertions(+), 47 deletions(-)

[Nikolas Zimmermann]

Comment on attachment 18004 [details]
Stop claiming to support SVG feature strings we don't

Good work, r=me.
Hopefully we can reeanble some soon....

[Eric Seidel (no email)]

Landed as r28891.