Bug 15469 - feature branch has 100's of implicit double -> float conversions
Summary: feature branch has 100's of implicit double -> float conversions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-11 16:17 PDT by Oliver Hunt
Modified: 2007-10-13 09:04 PDT (History)
0 users

See Also:

Attachments
Woo! Fix! (93.59 KB, patch)
2007-10-11 17:04 PDT, Oliver Hunt 		eric: review-
Details | Formatted Diff | Diff
Woo! Another Fix! (98.25 KB, patch)
2007-10-11 20:37 PDT, Oliver Hunt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2007-10-11 16:17:41 PDT 
feature bracnh has 100's of implicit double -> float conversions, these cause compile times failures is -Wshorten-64-to-32 is enabled, which it will need to be on trunk.
Comment 1 Oliver Hunt 2007-10-11 17:04:42 PDT 
Created attachment 16635 [details]
Woo! Fix!
Comment 2 Eric Seidel (no email) 2007-10-11 19:44:45 PDT 
Comment on attachment 16635 [details]
Woo! Fix!

Too many little issues discussed over IRC.  We should see a new version of this patch before landing.
Comment 3 Oliver Hunt 2007-10-11 20:37:16 PDT 
Created attachment 16638 [details]
Woo! Another Fix!
Comment 4 Oliver Hunt 2007-10-11 22:16:43 PDT 
Bug fix landed r26380