Bug 15461 – REGRESSION (r25438-r25449): Bookmarks Disappear

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Fahlsing]

When first opening Safari Version 3.0.3 (522.12.1) using WebKit r26183 the Bookmarks menu is empty upon first click. Clicks on the Bookmarks menu after the first time properly show the bookmarks.

[Mark Rowe (bdash)]

<rdar://problem/5535440>

[Mark Rowe (bdash)]

Does this happen with stock Safari 3.0.3?  Bookmarks are an application feature that is not implemented in WebKit, so I don't think this bug belongs in Bugzilla.

[Eric Milles]

I have Safari 3.0.3 and WebKit r26570 (although this problem has been showing up for over a week now for me).  Safari proper does not have any problem rendering the Bookmarks menu.  However, WebKit, as described above shows a (mostly) blank bookmarks menu on the first click and then on subsequent clicks, renders it correctly.

Also, I generally click-hold on the menu the first time because I anticipate dragging down.  When the menu comes up blank, I mouseup to release it and then just click-release rather than holding just to see if the bookmarks will show.  This might have something to do with it.

[Alexey Proskuryakov]

I think I'm seeing this for much longer, maybe since <http://trac.webkit.org/projects/webkit/changeset/25439>. ChangeLog for this patch promises similar behavior for icons, but not for bookmarks themselves.

[John Sullivan]

Alexey, that's interesting. I would expect the change for <http://trac.webkit.org/projects/webkit/changeset/25439> to cause menu items in Bookmarks and History menus to use the default blue icon in some cases where the menu items should be showing custom site icons, when a nightly WebKit is used with any released version of Safari, including the Safari 3.0.x beta releases. I would not expect the menu items to be completely blank though.

It would be helpful for anyone who can reproduce a problem like this to see if they can determine which nightly WebKit version first introduced the problem. (If it's indeed r25439, this would only require testing with two versions.)

It would also be helpful to check whether there are any console messages from Safari when the problem occurs.

[Alexey Proskuryakov]

I'm seeing this with r25667 now (with Safari 2). Unfortunately, this only happens intermittently, so regression testing is not very easy.

There is nothing in console when this happens. Interestingly, sometimes menu items are first drawn, and then immediately disappear.

The bug was originally reported against Macintosh Intel, and I'm on PowerPC - so this doesn't depend on architecture.

[John Sullivan]

When the bug occurs, are there blank spaces in the menu, or is the menu shorter than it should be? (A screenshot would be useful if you can get one.)

[Alexey Proskuryakov]

Created attachment 16678 [details]
screenshot

I've now found a way to reproduce this reliably: 
1. Launch WebKit.
2. Click on the "Bookmarks" item in menu bar.
3. After it opens (with all the menu items), move the mouse pointer down.

At this point, menu items disappear.

[Alexey Proskuryakov]

I can reproduce with r25449, but not with r25438.

[Alexey Proskuryakov]

(In reply to comment #8)
> 2. Click on the "Bookmarks" item in menu bar.

I mean: don't release the mouse button here.

> 3. After it opens (with all the menu items), move the mouse pointer down.

[David Kilzer (:ddkilzer)]

<rdar://problem/5511862>

[David Kilzer (:ddkilzer)]

Anyone reproduced this in Leopard?  This seems to only occur in Tiger.

[David Kilzer (:ddkilzer)]

I can't reproduce this on Safari 3.0.4 (523.12) on Mac OS X 10.4.11 (8S165).

Closing as RESOLVED/FIXED.  Ryan, please open a new bug if you see this behavior again.  Thanks!

[David Kilzer (:ddkilzer)]

Within an hour after closing this I saw it happen with a WebKit nightly build (probably r28129), but I've never seen it running Safari 3.0.4 directly, so I'm not inclined to open a new bug.