WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15442
Cease "hacking" the scope chains of nested functions
https://bugs.webkit.org/show_bug.cgi?id=15442
Summary
Cease "hacking" the scope chains of nested functions
Geoffrey Garen
Reported
2007-10-09 15:03:21 PDT
Broken off from
bug 14868
.
Attachments
Patch
(6.47 KB, patch)
2007-10-09 15:04 PDT
,
Geoffrey Garen
darin
: review+
Details
Formatted Diff
Diff
Patch2
(6.71 KB, patch)
2007-10-09 15:10 PDT
,
Geoffrey Garen
darin
: review+
Details
Formatted Diff
Diff
Patch3
(6.76 KB, patch)
2007-10-09 15:13 PDT
,
Geoffrey Garen
ggaren
: review+
Details
Formatted Diff
Diff
Patch4
(7.04 KB, patch)
2007-10-09 15:24 PDT
,
Geoffrey Garen
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2007-10-09 15:04:22 PDT
Created
attachment 16602
[details]
Patch
Darin Adler
Comment 2
2007-10-09 15:08:34 PDT
Comment on
attachment 16602
[details]
Patch r=me
Geoffrey Garen
Comment 3
2007-10-09 15:10:00 PDT
Created
attachment 16603
[details]
Patch2 Slightly updated test case and ChangeLog to reflect the full scope of this change.
Darin Adler
Comment 4
2007-10-09 15:10:49 PDT
Comment on
attachment 16603
[details]
Patch2 r=me
Geoffrey Garen
Comment 5
2007-10-09 15:13:28 PDT
Created
attachment 16604
[details]
Patch3 This one includes the updated layout test results, too. (I guess I'll r+ it myself.)
Geoffrey Garen
Comment 6
2007-10-09 15:24:56 PDT
Created
attachment 16605
[details]
Patch4 One more time with the right layout test results. This time for sure!
Geoffrey Garen
Comment 7
2007-10-15 13:54:10 PDT
Committed revision 26621.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug