Bug 15417 - Reproducible: Printing null values in Drosera console crashes
Summary: Reproducible: Printing null values in Drosera console crashes
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-07 20:56 PDT by Eric Seidel (no email)
Modified: 2008-05-17 09:56 PDT (History)
1 user (show)

See Also:


Attachments
the fix (1.07 KB, patch)
2007-10-08 09:10 PDT, Eric Seidel (no email)
darin: review-
Details | Formatted Diff | Diff
an alternative fix (1.31 KB, patch)
2007-10-08 09:29 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-07 20:56:08 PDT
Drosera crashed while using console to debug inspector

I was in the updateStyle function in ResourcePanel.js

I believe I typed:

styleNode.attributes[0]

And drosera crashed:

Date/Time:      2007-10-07 22:53:53.977 -0500
OS Version:     10.4.10 (Build 8R2218)
Report Version: 4

Command: Drosera
Path:    /Stuff/Users/eric/Projects/build/Debug/Drosera.app/Contents/MacOS/Drosera
Parent:  WindowServer [65]

Version: ??? (1.0)

PID:    16857
Thread: 0

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_PROTECTION_FAILURE (0x0002) at 0x00000000

Thread 0 Crashed:
0   com.apple.CoreFoundation 	0x9080f370 CFStringGetLength + 17
1   com.apple.JavaScriptCore 	0x0042fd1f JSStringCreateWithCFString + 35 (JSStringRefCF.cpp:41)
2   org.webkit.drosera       	0x00007e90 JSValueRefCreateWithNSString(OpaqueJSContext const*, NSString*) + 24 (DebuggerDocumentPlatform.mm:46)
3   org.webkit.drosera       	0x000085e8 DebuggerDocument::platformEvaluateScript(OpaqueJSContext const*, OpaqueJSString*, int) + 252 (DebuggerDocumentPlatform.mm:108)
4   org.webkit.drosera       	0x00003877 DebuggerDocument::evaluateScriptCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) + 363 (DebuggerDocument.cpp:125)
5   com.apple.JavaScriptCore 	0x0042f064 KJS::JSCallbackFunction::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 242 (JSCallbackFunction.cpp:63)
6   com.apple.JavaScriptCore 	0x0044f778 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 212 (object.cpp:94)
7   com.apple.JavaScriptCore 	0x0046ac1f KJS::FunctionCallDotNode::evaluate(KJS::ExecState*) + 815 (nodes.cpp:791)
8   com.apple.JavaScriptCore 	0x00452eae KJS::ArgumentListNode::evaluateList(KJS::ExecState*) + 68 (nodes.cpp:582)
9   com.apple.JavaScriptCore 	0x004a4786 KJS::ArgumentsNode::evaluateList(KJS::ExecState*) + 66 (nodes.h:367)
10  com.apple.JavaScriptCore 	0x0046b79e KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 476 (nodes.cpp:683)
11  com.apple.JavaScriptCore 	0x00458c69 KJS::ExprStatementNode::execute(KJS::ExecState*) + 143 (nodes.cpp:1764)
12  com.apple.JavaScriptCore 	0x00455d61 KJS::SourceElementsNode::execute(KJS::ExecState*) + 225 (nodes.cpp:2564)
13  com.apple.JavaScriptCore 	0x00458e04 KJS::BlockNode::execute(KJS::ExecState*) + 136 (nodes.cpp:1741)
14  com.apple.JavaScriptCore 	0x004596cb KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 39 (function.cpp:321)
15  com.apple.JavaScriptCore 	0x00459dff KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 567 (function.cpp:106)
16  com.apple.JavaScriptCore 	0x0044f778 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 212 (object.cpp:94)
17  com.apple.JavaScriptCore 	0x0046b827 KJS::FunctionCallResolveNode::evaluate(KJS::ExecState*) + 613 (nodes.cpp:695)
18  com.apple.JavaScriptCore 	0x00458c69 KJS::ExprStatementNode::execute(KJS::ExecState*) + 143 (nodes.cpp:1764)
19  com.apple.JavaScriptCore 	0x00455e6c KJS::SourceElementsNode::execute(KJS::ExecState*) + 492 (nodes.cpp:2570)
20  com.apple.JavaScriptCore 	0x00458e04 KJS::BlockNode::execute(KJS::ExecState*) + 136 (nodes.cpp:1741)
21  com.apple.JavaScriptCore 	0x00458b73 KJS::IfNode::execute(KJS::ExecState*) + 377 (nodes.cpp:1783)
22  com.apple.JavaScriptCore 	0x00455d61 KJS::SourceElementsNode::execute(KJS::ExecState*) + 225 (nodes.cpp:2564)
23  com.apple.JavaScriptCore 	0x00458e04 KJS::BlockNode::execute(KJS::ExecState*) + 136 (nodes.cpp:1741)
24  com.apple.JavaScriptCore 	0x00458b73 KJS::IfNode::execute(KJS::ExecState*) + 377 (nodes.cpp:1783)
25  com.apple.JavaScriptCore 	0x00455d61 KJS::SourceElementsNode::execute(KJS::ExecState*) + 225 (nodes.cpp:2564)
26  com.apple.JavaScriptCore 	0x00458e04 KJS::BlockNode::execute(KJS::ExecState*) + 136 (nodes.cpp:1741)
27  com.apple.JavaScriptCore 	0x004596cb KJS::DeclaredFunctionImp::execute(KJS::ExecState*) + 39 (function.cpp:321)
28  com.apple.JavaScriptCore 	0x00459dff KJS::FunctionImp::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 567 (function.cpp:106)
29  com.apple.JavaScriptCore 	0x0044f778 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 212 (object.cpp:94)
30  com.apple.WebCore        	0x0124b414 WebCore::JSAbstractEventListener::handleEvent(WebCore::Event*, bool) + 592 (kjs_events.cpp:116)
31  com.apple.WebCore        	0x0121d3ca WebCore::EventTargetNode::handleLocalEvents(WebCore::Event*, bool) + 352 (EventTargetNode.cpp:166)
32  com.apple.WebCore        	0x0121dbd7 WebCore::EventTargetNode::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>, int&, bool) + 1179 (EventTargetNode.cpp:224)
33  com.apple.WebCore        	0x0121e3d7 WebCore::EventTargetNode::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, int&, bool, WebCore::EventTarget*) + 329 (EventTargetNode.cpp:308)
34  com.apple.WebCore        	0x0121e453 WebCore::EventTargetNode::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, int&, bool) + 75 (EventTargetNode.cpp:292)
35  com.apple.WebCore        	0x0121ee04 WebCore::EventTargetNode::dispatchKeyEvent(WebCore::PlatformKeyboardEvent const&) + 218 (EventTargetNode.cpp:370)
36  com.apple.WebCore        	0x013ddf49 WebCore::EventHandler::keyEvent(WebCore::PlatformKeyboardEvent const&) + 449 (EventHandler.cpp:1465)
37  com.apple.WebCore        	0x013d889b WebCore::EventHandler::keyEvent(NSEvent*) + 455 (EventHandlerMac.mm:141)
38  com.apple.WebKit         	0x0023f3f5 -[WebHTMLView keyDown:] + 243 (WebHTMLView.mm:3560)
39  com.apple.AppKit         	0x93365be1 -[NSWindow sendEvent:] + 7377
40  com.apple.AppKit         	0x93357350 -[NSApplication sendEvent:] + 5023
41  com.apple.AppKit         	0x93281dfe -[NSApplication run] + 547
42  com.apple.AppKit         	0x93275d2f NSApplicationMain + 573
43  org.webkit.drosera       	0x00002ba6 main + 30 (main.m:32)
44  org.webkit.drosera       	0x00002516 _start + 216
45  org.webkit.drosera       	0x0000243d start + 41

Thread 1:
0   libSystem.B.dylib        	0x900248c7 semaphore_wait_signal_trap + 7
1   com.apple.Foundation     	0x9284a26c -[NSConditionLock lockWhenCondition:] + 39
2   com.apple.AppKit         	0x9335f270 -[NSUIHeartBeat _heartBeatThread:] + 377
3   com.apple.Foundation     	0x927f42e0 forkThreadForFunction + 123
4   libSystem.B.dylib        	0x90024227 _pthread_body + 84

Thread 2:
0   libSystem.B.dylib        	0x90009cd7 mach_msg_trap + 7
1   com.apple.CoreFoundation 	0x9082d2b3 CFRunLoopRunSpecific + 2014
2   com.apple.CoreFoundation 	0x9082cace CFRunLoopRunInMode + 61
3   com.apple.Foundation     	0x92850bc2 +[NSURLCache _diskCacheSyncLoop:] + 206
4   com.apple.Foundation     	0x927f42e0 forkThreadForFunction + 123
5   libSystem.B.dylib        	0x90024227 _pthread_body + 84

Thread 3:
0   libSystem.B.dylib        	0x90009cd7 mach_msg_trap + 7
1   com.apple.CoreFoundation 	0x9082d2b3 CFRunLoopRunSpecific + 2014
2   com.apple.CoreFoundation 	0x9082cace CFRunLoopRunInMode + 61
3   com.apple.Foundation     	0x92829a0f +[NSURLConnection(NSURLConnectionInternal) _resourceLoadLoop:] + 259
4   com.apple.Foundation     	0x927f42e0 forkThreadForFunction + 123
5   libSystem.B.dylib        	0x90024227 _pthread_body + 84

Thread 0 crashed with X86 Thread State (32-bit):
  eax: 0x00000000  ebx: 0x9080f36d  ecx: 0x004be3a4  edx: 0xffffffff
  edi: 0x0000370c  esi: 0x00000000  ebp: 0xbfffe258  esp: 0xbfffe230
   ss: 0x0000001f  efl: 0x00010286  eip: 0x9080f370   cs: 0x00000017
   ds: 0x0000001f   es: 0x0000001f   fs: 0x00000000   gs: 0x00000037

Binary Images Description:
    0x1000 -     0xcfff org.webkit.drosera ??? (1.0)	/Stuff/Users/eric/Projects/build/Debug/Drosera.app/Contents/MacOS/Drosera
  0x205000 -   0x2f2fff com.apple.WebKit 523.11+	/Stuff/Users/eric/Projects/build/Debug/WebKit.framework/Versions/A/WebKit
  0x3ff000 -   0x4a7fff com.apple.JavaScriptCore 523.11+	/Stuff/Users/eric/Projects/build/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore
  0x6a1000 -   0x6a3fff net.culater.SIMBL 0.8 (8)	/Library/InputManagers/SIMBL/SIMBL.bundle/Contents/MacOS/SIMBL
 0x1008000 -  0x16f6fff com.apple.WebCore 523.11+	/Stuff/Users/eric/Projects/build/Debug/WebCore.framework/Versions/A/WebCore
0x8fe00000 - 0x8fe4afff dyld 46.12	/usr/lib/dyld
0x90000000 - 0x90171fff libSystem.B.dylib 	/usr/lib/libSystem.B.dylib
0x901c1000 - 0x901c3fff libmathCommon.A.dylib 	/usr/lib/system/libmathCommon.A.dylib
0x901c5000 - 0x90202fff com.apple.CoreText 1.1.2 (???)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText
0x90229000 - 0x902fffff ATS 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS
0x9031f000 - 0x90774fff com.apple.CoreGraphics 1.258.75 (???)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
0x9080b000 - 0x908d3fff com.apple.CoreFoundation 6.4.7 (368.28)	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
0x90911000 - 0x90911fff com.apple.CoreServices 10.4 (???)	/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
0x90913000 - 0x90a07fff libicucore.A.dylib 	/usr/lib/libicucore.A.dylib
0x90a57000 - 0x90ad6fff libobjc.A.dylib 	/usr/lib/libobjc.A.dylib
0x90aff000 - 0x90b63fff libstdc++.6.dylib 	/usr/lib/libstdc++.6.dylib
0x90bd2000 - 0x90bd9fff libgcc_s.1.dylib 	/usr/lib/libgcc_s.1.dylib
0x90bde000 - 0x90c51fff com.apple.framework.IOKit 1.4.8 (???)	/System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
0x90c66000 - 0x90c78fff libauto.dylib 	/usr/lib/libauto.dylib
0x90c7e000 - 0x90f24fff com.apple.CoreServices.CarbonCore 682.26	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore
0x90f67000 - 0x90fcffff com.apple.CoreServices.OSServices 4.1	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices
0x91007000 - 0x91046fff com.apple.CFNetwork 129.21	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
0x91059000 - 0x91069fff com.apple.WebServices 1.1.3 (1.1.0)	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/WebServicesCore.framework/Versions/A/WebServicesCore
0x91074000 - 0x910f2fff com.apple.SearchKit 1.0.5	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit
0x91127000 - 0x91145fff com.apple.Metadata 10.4.4 (121.36)	/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata
0x91151000 - 0x9115ffff libz.1.dylib 	/usr/lib/libz.1.dylib
0x91162000 - 0x91301fff com.apple.security 4.5.2 (29774)	/System/Library/Frameworks/Security.framework/Versions/A/Security
0x913ff000 - 0x91407fff com.apple.DiskArbitration 2.1.1	/System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
0x9140e000 - 0x91415fff libbsm.dylib 	/usr/lib/libbsm.dylib
0x91419000 - 0x9143ffff com.apple.SystemConfiguration 1.8.6	/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
0x91451000 - 0x914cafff com.apple.audio.CoreAudio 3.0.4	/System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio
0x91518000 - 0x91518fff com.apple.ApplicationServices 10.4 (???)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
0x9151a000 - 0x91545fff com.apple.AE 314 (313)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE
0x91558000 - 0x9162cfff com.apple.ColorSync 4.4.9	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync
0x91667000 - 0x916e4fff com.apple.print.framework.PrintCore 4.6 (177.13)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore
0x91711000 - 0x917bafff com.apple.QD 3.10.24 (???)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD
0x917e0000 - 0x9182bfff com.apple.HIServices 1.5.2 (???)	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices
0x9184a000 - 0x91860fff com.apple.LangAnalysis 1.6.3	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis
0x9186c000 - 0x91886fff com.apple.FindByContent 1.5	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/FindByContent.framework/Versions/A/FindByContent
0x91890000 - 0x918cdfff com.apple.LaunchServices 182	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices
0x918e1000 - 0x918edfff com.apple.speech.synthesis.framework 3.5	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis
0x918f4000 - 0x91934fff com.apple.ImageIO.framework 1.5.5	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO
0x91947000 - 0x919f9fff libcrypto.0.9.7.dylib 	/usr/lib/libcrypto.0.9.7.dylib
0x91a3f000 - 0x91a55fff libcups.2.dylib 	/usr/lib/libcups.2.dylib
0x91a5a000 - 0x91a78fff libJPEG.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib
0x91a7d000 - 0x91adcfff libJP2.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib
0x91aee000 - 0x91af2fff libGIF.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib
0x91af4000 - 0x91b7afff libRaw.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRaw.dylib
0x91b7e000 - 0x91bbbfff libTIFF.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib
0x91bc1000 - 0x91bdbfff libPng.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
0x91be0000 - 0x91be2fff libRadiance.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib
0x91be4000 - 0x91cc2fff libxml2.2.dylib 	/usr/lib/libxml2.2.dylib
0x91cdf000 - 0x91cdffff com.apple.Accelerate 1.3.1 (Accelerate 1.3.1)	/System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate
0x91ce1000 - 0x91d6ffff com.apple.vImage 2.5	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage
0x91d76000 - 0x91d76fff com.apple.Accelerate.vecLib 3.3.1 (vecLib 3.3.1)	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib
0x91d78000 - 0x91dd1fff libvMisc.dylib 	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib
0x91dda000 - 0x91dfefff libvDSP.dylib 	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib
0x91e06000 - 0x9220ffff libBLAS.dylib 	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
0x92249000 - 0x925fdfff libLAPACK.dylib 	/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib
0x9262a000 - 0x92717fff libiconv.2.dylib 	/usr/lib/libiconv.2.dylib
0x92719000 - 0x92796fff com.apple.DesktopServices 1.3.6	/System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv
0x927d7000 - 0x92a07fff com.apple.Foundation 6.4.8 (567.29)	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
0x92b21000 - 0x92b38fff libGL.dylib 	/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib
0x92b43000 - 0x92b9bfff libGLU.dylib 	/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib
0x92baf000 - 0x92baffff com.apple.Carbon 10.4 (???)	/System/Library/Frameworks/Carbon.framework/Versions/A/Carbon
0x92bb1000 - 0x92bc1fff com.apple.ImageCapture 3.0.4	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture
0x92bcf000 - 0x92bd7fff com.apple.speech.recognition.framework 3.6	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition
0x92bdd000 - 0x92be2fff com.apple.securityhi 2.0.1 (24742)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI
0x92be8000 - 0x92c79fff com.apple.ink.framework 101.2.1 (71)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink
0x92c8d000 - 0x92c90fff com.apple.help 1.0.3 (32.1)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help
0x92c93000 - 0x92cb0fff com.apple.openscripting 1.2.5 (???)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting
0x92cc0000 - 0x92cc6fff com.apple.print.framework.Print 5.2 (192.4)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print
0x92ccc000 - 0x92d2ffff com.apple.htmlrendering 66.1 (1.1.3)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering
0x92d53000 - 0x92d94fff com.apple.NavigationServices 3.4.4 (3.4.3)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices
0x92dbb000 - 0x92dc8fff com.apple.audio.SoundManager 3.9.1	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound
0x92dcf000 - 0x92dd4fff com.apple.CommonPanels 1.2.3 (73)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels
0x92dd9000 - 0x930cefff com.apple.HIToolbox 1.4.9 (???)	/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
0x931d4000 - 0x931dffff com.apple.opengl 1.4.16	/System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL
0x9326f000 - 0x9326ffff com.apple.Cocoa 6.4 (???)	/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
0x93271000 - 0x93927fff com.apple.AppKit 6.4.8 (824.42)	/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
0x93ca8000 - 0x93d23fff com.apple.CoreData 91 (92.1)	/System/Library/Frameworks/CoreData.framework/Versions/A/CoreData
0x93d5c000 - 0x93e16fff com.apple.audio.toolbox.AudioToolbox 1.4.5	/System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox
0x93e59000 - 0x93e59fff com.apple.audio.units.AudioUnit 1.4.2	/System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit
0x93e5b000 - 0x9401cfff com.apple.QuartzCore 1.4.12	/System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
0x94062000 - 0x940a3fff libsqlite3.0.dylib 	/usr/lib/libsqlite3.0.dylib
0x940ab000 - 0x940e5fff libGLImage.dylib 	/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib
0x940ea000 - 0x94100fff com.apple.CoreVideo 1.4.1	/System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo
0x94290000 - 0x9429ffff libCGATS.A.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib
0x942a6000 - 0x942b1fff libCSync.A.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib
0x942fd000 - 0x94317fff libRIP.A.dylib 	/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib

Model: MacBookPro1,1, BootROM MBP11.0055.B08, 2 processors, Intel Core Duo, 2.16 GHz, 2 GB
Graphics: ATI Radeon X1600, ATY,RadeonX1600, PCIe, 256 MB
Memory Module: BANK 0/DIMM0, 1 GB, DDR2 SDRAM, 667 MHz
Memory Module: BANK 1/DIMM1, 1 GB, DDR2 SDRAM, 667 MHz
AirPort: spairport_wireless_card_type_airport_extreme (0x168C, 0x86), 1.1.9.3
Bluetooth: Version 1.9.0f8, 2 service, 0 devices, 1 incoming serial ports
Network Service: AirPort, AirPort, en1
Serial ATA Device: ST9100824AS, 93.16 GB
Parallel ATA Device: MATSHITADVD-R   UJ-857
USB Device: Built-in iSight, Micron, Up to 480 Mb/sec, 500 mA
USB Device: Apple Internal Keyboard / Trackpad, Apple Computer, Up to 12 Mb/sec, 500 mA
USB Device: IR Receiver, Apple Computer, Inc., Up to 12 Mb/sec, 500 mA
USB Device: Bluetooth USB Host Controller, Apple, Inc., Up to 12 Mb/sec, 500 mA
Comment 1 Eric Seidel (no email) 2007-10-07 21:02:02 PDT
This reproduced for me. :(
Comment 2 Eric Seidel (no email) 2007-10-07 21:54:42 PDT
var x = null
x

will crash Drosera.
Comment 3 Eric Seidel (no email) 2007-10-08 09:10:15 PDT
Created attachment 16588 [details]
the fix
Comment 4 Darin Adler 2007-10-08 09:20:45 PDT
Comment on attachment 16588 [details]
the fix

We need to null-check the result of stringOrNilFromWebScriptResult, rather than value itself.
Comment 5 Eric Seidel (no email) 2007-10-08 09:25:32 PDT
(In reply to comment #4)
> (From update of attachment 16588 [details] [edit])
> We need to null-check the result of stringOrNilFromWebScriptResult, rather than
> value itself.


stringOrNilFromWebScriptResult can only be nil when passed nil.  Just fixing the crash in the same way other locations have worked around JSValueRefCreateWithNSString not accepting nil.  stringOrNilFromWebScriptResult could be renamed?  or some alternative used.  But there is no need to check the result if you're passing in a non-nil (at least as it's currently coded).
Comment 6 Eric Seidel (no email) 2007-10-08 09:29:21 PDT
Created attachment 16589 [details]
an alternative fix
Comment 7 Eric Seidel (no email) 2007-10-08 09:30:29 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 16588 [details] [edit] [edit])
> > We need to null-check the result of stringOrNilFromWebScriptResult, rather than
> > value itself.
> 
> 
> stringOrNilFromWebScriptResult can only be nil when passed nil.  Just fixing
> the crash in the same way other locations have worked around
> JSValueRefCreateWithNSString not accepting nil.  stringOrNilFromWebScriptResult
> could be renamed?  or some alternative used.  But there is no need to check the
> result if you're passing in a non-nil (at least as it's currently coded).
> 

Bdash points out I was wrong.  stringOrNilFromWebScriptResult return nil.  The second fix is better.
Comment 8 Darin Adler 2007-10-08 09:40:43 PDT
Comment on attachment 16589 [details]
an alternative fix

r=me
Comment 9 Eric Seidel (no email) 2007-10-08 10:03:04 PDT
landed on feature-branch as r26106.
Comment 10 Timothy Hatcher 2008-05-17 09:56:05 PDT
Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.