RESOLVED INVALID 15410
GTK: compilation error, incomplete rename of marshalling functions 
https://bugs.webkit.org/show_bug.cgi?id=15410
Summary GTK: compilation error, incomplete rename of marshalling functions
Lars Lindner
Reported 2007-10-07 11:32:39 PDT
With revision 26101 or a previous one the GTK build target was broken. Compilation fails with: /home/lars/oss/WebKit/WebKitBuild/Release/lib/libWebKitGtk.so: undefined reference to `webkit_marshal_VOID__STRING_STRING' collect2: ld returned 1 exit status make[1]: *** [GtkLauncher] Fehler 1 make[1]: Leaving directory `/home/lars/oss/WebKit/WebKitBuild/Release/WebKitTools/GtkLauncher' make: *** [sub-WebKitTools-GtkLauncher-make_default-ordered] Fehler 2 It seems like the marshalling functions were renamed from webkit_marshal_* to webkit_gtk_marshal_* without adapting the code at some places. Affected files : gtk/Api/webkitgtkpage.cpp gtk/Api/webkitgtkframe.cpp
Attachments
Fix for GTK compilation issues (3.07 KB, patch)
2007-10-07 11:41 PDT, Lars Lindner 		aroben: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lars Lindner
Comment 1 2007-10-07 11:41:09 PDT
Created attachment 16575 [details] Fix for GTK compilation issues
Adam Roben (:aroben)
Comment 2 2007-10-07 16:03:31 PDT
Comment on attachment 16575 [details] Fix for GTK compilation issues This patch moves things in the wrong direction. All the WebKit/gtk API methods were recently renamed from webkit_gtk_* to just webkit_*. We need to rename these marshallers as well.
Mark Rowe (bdash)
Comment 3 2007-10-07 18:57:24 PDT
I suspect the generated file webkitgtk-marshal.h/cpp has not been regenerated in your case. I cannot see anything incorrect in the source that you indicate, so I would suggest you try a clean build and see if that improves things.
Lars Lindner
Comment 4 2007-10-08 08:22:03 PDT
You are right. Compiling with a clean checkout solves the problem. Thanks for the help! So this problem report is invalid and can be closed.
Note You need to log in before you can comment on or make changes to this bug.