Bug 15337 - Efficiently handle regexp property identifiers for 19% speedup on Celtic Kane regexp test
Summary: Efficiently handle regexp property identifiers for 19% speedup on Celtic Kane...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL: http://celtickane.com/projects/jsspee...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-01 22:13 PDT by Maciej Stachowiak
Modified: 2007-10-02 20:38 PDT (History)
0 users

See Also:


Attachments
speedup patch (5.40 KB, patch)
2007-10-01 22:52 PDT, Maciej Stachowiak
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-10-01 22:13:59 PDT
The Celtic Kane regexp benchmark spends a lot of its time making Identifiers for a lot of the custom properties kept on RegExp related objects. It would work much better to use the CommonIdentifiers technique for these.
Comment 1 Maciej Stachowiak 2007-10-01 22:52:28 PDT
Created attachment 16495 [details]
speedup patch
Comment 2 Mark Rowe (bdash) 2007-10-02 02:24:25 PDT
Comment on attachment 16495 [details]
speedup patch

r=me