Bug 15326 - innerHTML updates layout every time (hurts celtickane JS benchmark)
Summary: innerHTML updates layout every time (hurts celtickane JS benchmark)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 523.x (Safari 3)
Hardware: All OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-30 02:19 PDT by Maciej Stachowiak
Modified: 2007-10-02 20:11 PDT (History)
0 users

See Also:


Attachments
don't update layout for innerHTML (1.14 KB, patch)
2007-09-30 02:21 PDT, Maciej Stachowiak
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-09-30 02:19:30 PDT
innerHTML updates layout every time it is read. This can be seen on "http://celtickane.com/projects/jsspeed2007.php", where on the DOM test (actually primarily a test of innerHTML) we are currently the slowest of any browser.
Comment 1 Maciej Stachowiak 2007-09-30 02:21:42 PDT
Created attachment 16467 [details]
don't update layout for innerHTML
Comment 2 Eric Seidel (no email) 2007-09-30 06:48:22 PDT
Comment on attachment 16467 [details]
don't update layout for innerHTML

I also looked, it appears that createMarkup(Node*... does not actually touch the render tree (renderer()) so I agree, this looks safe.  r=me
Comment 3 Maciej Stachowiak 2007-10-02 01:23:10 PDT
Incidentally this patch is a 65% speedup on that one test in the benchmark.