Bug 15281 - WebKit hits ASSERT when attempting to drag an image from an SVG
Summary: WebKit hits ASSERT when attempting to drag an image from an SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 15069 15308
  Show dependency tree / graph
 
Reported: 2007-09-25 12:42 PDT by Eric Seidel (no email)
Modified: 2007-10-01 22:29 PDT (History)
0 users

See Also:

Attachments
the fix (97.32 KB, patch)
2007-09-25 13:07 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
fix, also fix --no-svg build on feature-branch (98.83 KB, patch)
2007-09-25 14:30 PDT, Eric Seidel (no email) 		oliver: review+
Details | Formatted Diff | Diff
updated patch for rebased feature-branch (mostly project file changes) (175.70 KB, patch)
2007-10-01 22:16 PDT, Eric Seidel (no email) 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-09-25 12:42:52 PDT 
WebKit hits ASSERT when attempting to drag an image from an SVG

In the end, this seems to have been due to a lack of [DOMSVGImageElement _subresources], which I implemented.  In order to make it work, I also had to export DOMSVG symbols from WebCore, as well as teach WebKit how to copy over the DOMSVG* header files into it's PrivateHeaders.
Comment 1 Eric Seidel (no email) 2007-09-25 13:07:32 PDT 
Created attachment 16389 [details]
the fix
Comment 2 Eric Seidel (no email) 2007-09-25 14:30:33 PDT 
Created attachment 16391 [details]
fix, also fix --no-svg build on feature-branch
Comment 3 David Kilzer (:ddkilzer) 2007-09-26 07:14:39 PDT 
Comment on attachment 16391 [details]
fix, also fix --no-svg build on feature-branch

>+        This only affects Debug builds, and the ability to save SVGs as WebArchives
>+        neither are testable via DumpRenderTree.

I don't believe this statement is true.  It's possible for DRT to save pages as WebArchives now.  See the tests in the LayoutTests/webarchive/ directory.
Comment 4 Eric Seidel (no email) 2007-09-28 09:45:59 PDT 
The problem SVG was similar to (but not identical to) this one:
http://people.mozilla.com/~vladimir/demos/photos.svg
Comment 5 Oliver Hunt 2007-10-01 19:13:38 PDT 
This bugs was skipped when rebasing feature-branch and needs to be updated.
Comment 6 Eric Seidel (no email) 2007-10-01 22:16:07 PDT 
Created attachment 16494 [details]
updated patch for rebased feature-branch (mostly project file changes)
Comment 7 Oliver Hunt 2007-10-01 22:19:45 PDT 
Comment on attachment 16494 [details]
updated patch for rebased feature-branch (mostly project file changes)

rs=me
Comment 8 Eric Seidel (no email) 2007-10-01 22:29:41 PDT 
Landed (again) as r25906.