Bug 15278 - Text highlight does a highlight around the entire run
Summary: Text highlight does a highlight around the entire run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-25 10:12 PDT by George Staikos
Modified: 2007-09-26 04:40 PDT (History)
0 users

See Also:

Attachments
A potential fix (603 bytes, patch)
2007-09-25 10:12 PDT, George Staikos 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2007-09-25 10:12:00 PDT 
The text highlight code in InlineTextBox.cpp:666 does a highlight of the entire run instead of the part we're searching for.  Attached patch passes the missing parameters to select only the appropriate portions.
Comment 1 George Staikos 2007-09-25 10:12:48 PDT 
Created attachment 16387 [details]
A potential fix
Comment 2 John Sullivan 2007-09-25 15:03:34 PDT 
Comment on attachment 16387 [details]
A potential fix

This fixes a bug in a code path that I wrote a long time ago for Safari's use, but which Safari no longer uses. r=me
Comment 3 George Staikos 2007-09-26 04:40:04 PDT 
Checked in r25761