Bug 15214 – SVG link with target="_top" opens new window

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Jeff Schiller]

Safari 3.0.3 Beta

Clicking the link opens a new window (target="_top" should replace the top-most frame as Firefox, Opera and IE+ASV3 do.

[Jeff Schiller]

Created attachment 16292 [details]
Simple test case

[David Kilzer (:ddkilzer)]

Confirmed difference in behavior between Firefox 2.0.0.6 and Opera 9.22 versus a local debug build of WebKit r25545 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218).

[Eric Seidel (no email)]

As part of fixing this, I made sure we passed all the SVG WG test cases.  This one is relevant to this code change, but the test seems wrong:
http://www.w3.org/Graphics/SVG/Test/20061213/htmlEmbedHarness/full-linking-a-07-t.html

specifically:
The bottom-most (blue) arrows links to the same external SVG file, but with xlink:show="replace". Both the left and the right blue arrows should produce the image of the linkingToc-t.svg in a new frame.

The left arrow should not open a new window, as xlink:replace behaves like target="_self" according to the xlink spec.
http://www.w3.org/TR/xlink/#show-att

[Eric Seidel (no email)]

One remaining question is "who wins?" when you have conflicting attributes, such as target="_self" and xlink:show="new".  Currently I've coded things so that target always wins.

[Eric Seidel (no email)]

Created attachment 16386 [details]
a fix

[Rob Buis]

Comment on attachment 16386 [details]
a fix

r=me

[Eric Seidel (no email)]

Landed on the feature branch as r25729.

You should be able to verify once the build shows up at:
http://nightly.webkit.org/builds/mac-feature-branch/1