Bug 15203 - [gtk] Don't use FcBool in backend code
Summary: [gtk] Don't use FcBool in backend code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-13 09:07 PDT by Sven Herzberg
Modified: 2007-09-14 02:55 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (1.10 KB, patch)
2007-09-13 09:12 PDT, Sven Herzberg 		aroben: review+
Details | Formatted Diff | Diff
Proposed Patch v2 (1.13 KB, patch)
2007-09-13 09:42 PDT, Sven Herzberg 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Herzberg 2007-09-13 09:07:49 PDT 
FcBool is only available if the system provides fontconfig. If webkit/gtk should be portable to other platforms (think of Gtk+/MacOS or GTK+/Win) fontconfig won't be available.

Patch follows.
Comment 1 Sven Herzberg 2007-09-13 09:12:56 PDT 
Created attachment 16278 [details]
Proposed Patch
Comment 2 Adam Roben (:aroben) 2007-09-13 09:29:15 PDT 
Comment on attachment 16278 [details]
Proposed Patch

+    static bool initialized = false;

You don't need to initialize this variable to false (that will happen automatically as a result of it being declared static).

Please leave the "Reviewed by NOBODY (OOPS!)." line that prepare-ChangeLog generates for you, as we have pre-commit hooks that prevent anyone from checking in an unreviewed change this way.

r=me
Comment 3 Sven Herzberg 2007-09-13 09:42:04 PDT 
Created attachment 16279 [details]
Proposed Patch v2
Comment 4 Adam Roben (:aroben) 2007-09-13 09:50:44 PDT 
Comment on attachment 16279 [details]
Proposed Patch v2

r=me. Thanks for the fixes!
Comment 5 Mark Rowe (bdash) 2007-09-14 02:55:18 PDT 
Landed in r25561.