Bug 15176 - run-launcher overwrites LD_LIBRARY_PATH
Summary: run-launcher overwrites LD_LIBRARY_PATH
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-11 02:56 PDT by Sven Herzberg
Modified: 2007-09-11 09:42 PDT (History)
2 users (show)

See Also:


Attachments
Proposed Patch (1.01 KB, patch)
2007-09-11 02:59 PDT, Sven Herzberg
ddkilzer: review-
Details | Formatted Diff | Diff
Final Patch (1.15 KB, patch)
2007-09-11 08:35 PDT, Sven Herzberg
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Herzberg 2007-09-11 02:56:39 PDT
The run-launcher script contains this line of code which breaks running webkit against libraries that also need to specify LD_LIBRARY_PATH:
$ENV{LD_LIBRARY_PATH} = $productDir;

I'm going to attach a fix for this.
Comment 1 Sven Herzberg 2007-09-11 02:59:34 PDT
Created attachment 16249 [details]
Proposed Patch
Comment 2 Richard Hult 2007-09-11 03:05:20 PDT
And while at it, shouldn't the directory really be $productDir/lib?
Comment 3 David Kilzer (:ddkilzer) 2007-09-11 06:47:32 PDT
(In reply to comment #2)
> And while at it, shouldn't the directory really be $productDir/lib?

Please file a separate bug for this, or check with Gtk developers on IRC using irc.freenode.net on the #webkit channel.  The existing script appears to be working, so I'm hesitant to mix that change with this one.

Comment 4 David Kilzer (:ddkilzer) 2007-09-11 06:52:38 PDT
Comment on attachment 16249 [details]
Proposed Patch

Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a "Use of uninitialized value" warning to be printed in the case where it's not set.  You should do something like:

$ENV{LD_LIBRARY_PATH} = $ENV{LD_LIBRARY_PATH} ? "$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir;

Setting review- flag to fix this issue.

Please set the "review?" flag on patches in the future if you'd like them to be reviewed.  (There is no need to set a email address with the review flag.)

Also, please create a ChangeLog entry with the patch.  (The description you have in your git commit message is great!)

http://webkit.org/coding/contributing.html

Thanks for reporting this bug!
Comment 5 Sven Herzberg 2007-09-11 08:35:58 PDT
Created attachment 16255 [details]
Final Patch
Comment 6 David Kilzer (:ddkilzer) 2007-09-11 09:22:35 PDT
Comment on attachment 16255 [details]
Final Patch

Great!  r=me
Comment 7 David Kilzer (:ddkilzer) 2007-09-11 09:42:32 PDT
$ svn commit WebKitTools/ChangeLog WebKitTools/Scripts/run-launcher 
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/run-launcher
Transmitting file data ..
Committed revision 25492.