REGRESSION: Can't drag text as element when user-select is set to none

[Dustin MacDonald]

Dragging text as an element using the -khtml-user-drag selector does not work. The text selector cursor appears as if the text was selectable and the element cannot be dragged. This used to work in previous WebKit builds. Try code example below:

<div style="-khtml-user-select:none;-khtml-user-drag:element;">drag text</div>

Probably regressed in <http://trac.webkit.org/projects/webkit/changeset/25057>.

[David Kilzer (:ddkilzer)]

<rdar://problem/5446484>

[David Kilzer (:ddkilzer)]

Created attachment 16155 [details]
Test case

[Darin Adler]

Is there a real site depending on this? How did you discover this problem? It's important that we understand the impact of this so we can gauge the importance of a quick fix.

[Dustin MacDonald]

I am working on a WebKit-based app for Mac OS X which uses JavaScript drag and drop extensively. I noticed the change in the latest Leopard seed (9A527).

After reviewing the 25057 changeset that [e-mail] posted, it appears that the desired functionality can now be obtained using "-khtml-user-select: ignore". So, a workaround is available, but I imagine this change could break lots of third party WebKit-based apps and Dashboard widgets.

[Darin Adler]

(In reply to comment #5)
> I imagine this change could break lots of third party WebKit-based apps and Dashboard widgets.

Please add a note here if anyone reading this discovers a specific WebKit-based application or Dashboard widget that is affected.

(In reply to comment #1)
> Probably regressed in <http://trac.webkit.org/projects/webkit/changeset/25057>.

That change has been rolled out and eventually replaced by <http://trac.webkit.org/projects/webkit/changeset/25641>.

(In reply to comment #5)
> After reviewing the 25057 changeset that [e-mail] posted, it appears
> that the desired functionality can now be obtained using "-khtml-user-select:
> ignore".

After r25641, this workaround is no longer possible.

[Tom Brown]

This bug is causing the drag and drop feature in my web application to not work. Have any other workarounds been found?

My web application is: http://www.bungeelabs.com/

[Mirela Correa]

I am facing this problem in my we application.

Any news on this bug? Will it be fixed? Any workarounds?

Thanks!

[Jessie Berlin]

A temporary workaround:

<span style="-webkit-user-drag: element;" ondragstart="SpanDragHandler()">
<span style="z-index: -1; position: relative; -webkit-user-select: none;">drag me</span>
</span>

The z-index makes it so that the outer span is hit-tested first.

[Mark Rowe (bdash)]

I've got a fix for this, and will post it after I've come up with a regression test.

[Mark Rowe (bdash)]

Created attachment 31600 [details]
Patch

Comment on attachment 31600 [details]
Patch

> +        RenderStyle *style = renderer()->style();

The * should go next to RenderStyle. r=me

[Mark Rowe (bdash)]

Fixed in r44902.

[David Kilzer (:ddkilzer)]

(In reply to comment #15)
> Fixed in r44902.

http://trac.webkit.org/changeset/44902