Bug 15071 - [cairo] SVG skews are incorrect
Summary: [cairo] SVG skews are incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.croczilla.com/svg/samples/...
Keywords: Cairo, Gtk
Depends on:
Blocks:
 
Reported: 2007-08-24 10:44 PDT by Alp Toker
Modified: 2007-08-24 13:17 PDT (History)
0 users

See Also:

Attachments
Proposed fix (1.25 KB, patch)
2007-08-24 10:52 PDT, George Wright 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-08-24 10:44:20 PDT 
The SVG sample at http://www.croczilla.com/svg/samples/skew1/skew1.xml exhibits incorrect skewing, suggesting a problem with shear transforms in the Cairo graphics backend.
Comment 1 George Wright 2007-08-24 10:52:58 PDT 
Created attachment 16107 [details]
Proposed fix
Comment 2 Adam Roben (:aroben) 2007-08-24 11:18:18 PDT 
Comment on attachment 16107 [details]
Proposed fix

The fix looks fine, but this needs a regression test. I'll r+ the patch once we have a test with results.
Comment 3 Oliver Hunt 2007-08-24 12:32:21 PDT 
Comment on attachment 16107 [details]
Proposed fix

This is gtk only and the gtk port does not yet support drt.
Comment 4 Oliver Hunt 2007-08-24 12:43:38 PDT 
Sending        ChangeLog
Sending        platform/graphics/cairo/AffineTransformCairo.cpp
Transmitting file data ..
Committed revision 25214.
Comment 5 Adam Roben (:aroben) 2007-08-24 13:17:30 PDT 
Oliver says that we have 3 tests that already cover SVG skew: svg/W3C-SVG-1.1/coords-trans-01-b, svg/W3C-SVG-1.1/pservers-grad-07-b, svg/W3C-SVG-1.1/linking-a-05-t. Presumably those tests would have failed on Gtk if Gtk were able to run the regression tests. So that's why we don't need a new test for this fix.