Bug 15063 - REGRESSION (r25151): Switching to a tab waiting for first data does not clear the window
Summary: REGRESSION (r25151): Switching to a tab waiting for first data does not clear...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar, Regression
: 16417 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-23 13:49 PDT by mitz
Modified: 2008-11-09 12:20 PST (History)
6 users (show)

See Also:


Attachments
patch (8.80 KB, patch)
2008-11-09 11:39 PST, Darin Adler
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-08-23 13:49:47 PDT
Summary:
Switching from one tab to a newly created tab that has not gotten beyond a certain stage of loading leaves behind the image of the first tab. Forcing redraw may clear the old image.

Steps to reproduce:
1) Open any page in a first tab.
2) Create a new empty tab.
3) In the empty tab, type a URL that takes long to start loading (one way to fake this is to run "nc -l 9999" and go to <http://127.0.0.1:9999/>) and press Return.
4) Use the keyboard to switch to the first tab and then back to the new tab.

Expected results:
When switching to the new tab in step 4, it should display a blank page.

Actual results:
When switching to the new tab in step 4, it displayed the contents of the first tab.

Regression:
Regressed between r25065 and TOT. My guess is <http://trac.webkit.org/projects/webkit/changeset/25151>.
Comment 1 Matt Lilek 2007-08-23 15:53:53 PDT
I've seen this on Windows too.
Comment 2 Darren Collins 2007-08-25 15:34:45 PDT
Another way to reproduce (only tested on XP) is to set "New Window Opens With" preference to "Empty Page".  When Safari is started the "Empty Page" does not get painted, so windows behind Safari bleed through.  Dragging windows across the "Empty Page" show it is not getting painted.
Comment 3 mitz 2007-08-28 09:37:19 PDT
(In reply to comment #2)
> Another way to reproduce (only tested on XP) is to set "New Window Opens With"
> preference to "Empty Page".  When Safari is started the "Empty Page" does not
> get painted, so windows behind Safari bleed through.  Dragging windows across
> the "Empty Page" show it is not getting painted.

I believe this is <rdar://problem/5424801>, fixed in <http://trac.webkit.org/projects/webkit/changeset/25270>.
Comment 4 Darren Collins 2007-08-28 14:43:40 PDT
(In reply to comment #3)

Confirmed "Empty Page" now paints on XP on r25279.
Comment 5 David Kilzer (:ddkilzer) 2007-08-28 21:12:12 PDT
Marking resolved per Comment #4.

Comment 6 mitz 2007-08-28 22:27:18 PDT
(In reply to comment #5)
> Marking resolved per Comment #4.

What's resolved is the Windows variant of the bug, described in comment #2. The original bug described in comment #0 is still reproducible on Mac.
Comment 7 Adele Peterson 2007-08-30 17:31:36 PDT
<rdar://problem/5452227>
Comment 8 John Sullivan 2008-01-17 12:26:25 PST
Some updated info from the radar:

This regressed with the first change in <http://trac.webkit.org/projects/webkit/changeset/25151/trunk/WebCore/loader/FrameLoader.cpp>

The problem is that the WebHTMLView has no size (0,0) because there hasn't been any layout that forces a size. Manually resizing cures the problem because it forces a layout via an inLiveResize check in [WebDynamicScrollBarsView updateScrollers].
Comment 9 David Kilzer (:ddkilzer) 2008-01-19 03:45:18 PST
This sounds a lot like Bug 16417.

Comment 10 Darin Adler 2008-11-09 11:39:46 PST
Created attachment 25003 [details]
patch
Comment 11 Darin Adler 2008-11-09 11:42:41 PST
*** Bug 16417 has been marked as a duplicate of this bug. ***
Comment 12 John Sullivan 2008-11-09 12:15:34 PST
Comment on attachment 25003 [details]
patch

Most excellent.
Comment 13 Darin Adler 2008-11-09 12:20:59 PST
http://trac.webkit.org/changeset/38245