Bug 15043 – KJS::allocateBlock(): posix_memalign takes a void** as its first parameter

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Ryan Leavengood]

This clearly is not code that any current port uses, since it should not compile without the change attached. But my port makes use of this since it was already in the code, instead of making another #elsif. But as shown by the documentation here:

http://www.opengroup.org/onlinepubs/000095399/functions/posix_memalign.html

the function is being called incorrectly. The simple patch attached corrects that.

[Ryan Leavengood]

Created attachment 16066 [details]
Fix to posix_memalign call in KJS::allocateBlock

[Darin Adler]

Comment on attachment 16066 [details]
Fix to posix_memalign call in KJS::allocateBlock

I also don't think the reinterpret_cast is needed on the next line.

[Ryan Leavengood]

Would you like me to make that change and create another patch, or could you take care of it? :)

[Ryan Leavengood]

Created attachment 16067 [details]
The same patch, with the removal of the reinterpret_cast in the memset call

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> This clearly is not code that any current port uses, since it should not
> compile without the change attached. But my port makes use of this since it was
> already in the code, instead of making another #elsif. [...]

What port are you working on?  :)

[Ryan Leavengood]

(In reply to comment #5)
> 
> What port are you working on?  :)

I am porting WebKit to Haiku, http://haiku-os.org. It is a clone of BeOS.

[Maciej Stachowiak]

Comment on attachment 16067 [details]
The same patch, with the removal of the reinterpret_cast in the memset call

r=me

Probably other ports could use memalign too, but don't set the right ifdef so they get the generic mmap-based version.

[Mark Rowe (bdash)]

Landed in r25296.