Bug 15026 - prepare-ChangeLog should list new tests in WebCore/ChangeLog
Summary: prepare-ChangeLog should list new tests in WebCore/ChangeLog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Enhancement
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-20 14:22 PDT by Adam Roben (:aroben)
Modified: 2007-08-20 14:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch with ChangeLog (4.64 KB, patch)
2007-08-20 14:26 PDT, Adam Roben (:aroben)
ddkilzer: review-
Details | Formatted Diff | Diff
Updated to follow the style Darin mentioned (4.60 KB, patch)
2007-08-20 14:35 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2007-08-20 14:22:55 PDT
prepare-ChangeLog should list any new regression tests in WebCore/ChangeLog (it already prints out a warning if no tests are added or changed).

Patch coming.
Comment 1 Adam Roben (:aroben) 2007-08-20 14:26:34 PDT
Created attachment 16040 [details]
Patch with ChangeLog

For reference, here's how the list looks:

2007-08-20  Adam Roben  <aroben@apple.com>

        Reviewed by NOBODY (OOPS!).

        Added tests: css1/basic/new-test.html
                     fast/loader/yay.html
Comment 2 Darin Adler 2007-08-20 14:29:20 PDT
Comment on attachment 16040 [details]
Patch with ChangeLog

Adam, "Added xxx" is not the format we've been using for tests.

Look at <http://trac.webkit.org/projects/webkit/changeset/25010> for an example of the format Maciej suggested and I've been following.
Comment 3 Adam Roben (:aroben) 2007-08-20 14:35:46 PDT
Created attachment 16041 [details]
Updated to follow the style Darin mentioned

Here's an updated patch that uses the "Test[s]:" format.
Comment 4 David Kilzer (:ddkilzer) 2007-08-20 14:36:18 PDT
Comment on attachment 16040 [details]
Patch with ChangeLog

r=me!
Comment 5 David Kilzer (:ddkilzer) 2007-08-20 14:36:48 PDT
Comment on attachment 16040 [details]
Patch with ChangeLog

Geez...you study the code for just a couple minutes....  :)
Comment 6 David Kilzer (:ddkilzer) 2007-08-20 14:39:14 PDT
Comment on attachment 16041 [details]
Updated to follow the style Darin mentioned

r=me!
Comment 7 Darin Adler 2007-08-20 14:39:34 PDT
Comment on attachment 16041 [details]
Updated to follow the style Darin mentioned

r=dkilzer (and me)
Comment 8 Adam Roben (:aroben) 2007-08-20 14:47:24 PDT
Landed as r25160