Bug 15010 – REGRESSION (r25000-r25065): Table rendering broken by a recent nightly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Andrew]

If you visit the site it should be pretty clear what the problem is, it appears the table is not being rendered to it's complete length. It renders incorrectly in r25145 I believe, but can't be 100% sure, that this regression was introduced in the last week or so.

This could be a result of <http://trac.webkit.org/projects/webkit/changeset/25011>.

Created attachment 16024 [details]
Partial reduction

When the browser window is sufficiently wide, the innermost table suddenly collapses.

The problem is that as a result of r25011, there are some huge max widths involved in various computations in AutoTableLayout.cpp and when computing integer ratios such as

available * m_layoutStruct[i].effMaxWidth / totalAuto

or

maxNonPercent * 100 * percentScaleFactor / max(remainingPercent, epsilon)

the intermediate products overflow and you get negative numbers. Not sure exactly how to fix it.

[Geoffrey Garen]

Silly idea: perform the division before the multiplication?

Another silly idea: enforce a "max max width?"

[Geoffrey Garen]

<rdar://problem/5423956>

(In reply to comment #4)
> Silly idea: perform the division before the multiplication?

That will introduce huge errors in many cases due to rounding.

> Another silly idea: enforce a "max max width?"

Possible, but may reintroduce the bug fixed by r25011.

I also thought of 
- using a 'long long' for the intermediate product, but I don't know if that's guaranteed to work (that is, allow for bigger values) in all platforms;
- using floating-point math to compute the scaling factors.

[Darin Adler]

(In reply to comment #0)
> If you visit the site

What site?

[Matt Lilek]

(In reply to comment #7)
> (In reply to comment #0)
> > If you visit the site
> 
> What site?
> 

I believe <http://community.nethosted.co.uk/>.  For some reason it was cleared from the URL field.

[Maciej Stachowiak]

floating point math would probably give the best rounding behavior. And it would be easy to check for overflowing the range of an int once at the end.

Created attachment 16052 [details]
Use floating point arithmetic for max widths and add a cap

[Darin Adler]

Comment on attachment 16052 [details]
Use floating point arithmetic for max widths and add a cap

r=me

[Adele Peterson]

Committed revision 25171.