Bug 14973 – Some .strip files are removed but not generated

• Status: NEW
• Component: Platform

[Artem Ananiev]

WebCore.pro contains the following line:

cssprops.commands = $(COPY_FILE) ${QMAKE_FILE_NAME} tmp && cd tmp && 
perl $$PWD/css/makeprop.pl && $(DEL_FILE) ${QMAKE_FILE_BASE}.strip 
${QMAKE_FILE_BASE}.in ${QMAKE_FILE_BASE}.gperf

It first launches makeprop.pl perl script and then removes 3 temporary files: .strip, .in and .gperf. The problem is that since some recent WebKit revision, the script doesn't generate .strip file, so $(DEL_FILE) fails with an error.

This happens for at least two files: CSSValueKeywords.strip and CSSPropertyNames.strip

[David Kilzer (:ddkilzer)]

Thanks for filing a bug, Artem.  I apologize, I should have looked at the diff closer:

http://trac.webkit.org/projects/webkit/changeset/24603

Basically, the *.strip files were an artifact of the old shell scripts.  With the new Perl scripts, they aren't needed anymore and thus they don't need to be removed anymore.

It's possible after upgrading that you may have old copies sitting in a directory (that will never get removed by the build process anymore), but it's safe to delete them.

The fact that they're called *.strip files is not meaningful--there's nothing special about them related to the strip(1) command.  It just meant that comments had been stripped from the *.in files that they were created from.

[Artem Ananiev]

Please, look at the current svn sources:

http://svn.webkit.org/repository/webkit/trunk/WebCore/WebCore.pro

It's clearly seen that $(DEL_FILE) ${QMAKE_FILE_BASE}.strip is still there (note that 'rm' is changed with '$(DEL_FILE)'), however it must have been deleted by changeset 24603. Is 'trunk' a current branch?

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> It's clearly seen that $(DEL_FILE) ${QMAKE_FILE_BASE}.strip is still there
> (note that 'rm' is changed with '$(DEL_FILE)'), however it must have been
> deleted by changeset 24603. Is 'trunk' a current branch?

Oops!  My bad, I thought I saw that being removed from r24603.  The 'trunk' is the head of the source tree, and you are correct, there are still references to removing *.strip files there.

[Ahmad Saleem]

This commit replaced 'makeprop.pl' - https://github.com/WebKit/WebKit/commit/9047d68a603f31c0aadda6b7e42f3d9fff946006

So do we need to anymore?