Bug 14912 – REGRESSION: text inputs are not scrolled to make inline input visible

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Alexey Proskuryakov]

To reproduce, type a lot of garbage in "Summary" text of this bug using Kotoeri Hiragana.

As you type, the insertion point will move outside the field. AppKit text input fields scroll to make the insertion point visible (there's a special Carbon Event parameter that an IM can pass to request some part of the text to be visible; I don't know if AppKit uses it, or just follows the insertion point).

[Mark Rowe (bdash)]

<rdar://problem/5403724>

[Darin Adler]

Created attachment 15947 [details]
patch

[John Sullivan]

Comment on attachment 15947 [details]
patch

r=me

[Darin Adler]

r25027

[Alexey Proskuryakov]

(In reply to comment #0)
> (there's a special Carbon Event parameter that an IM can pass to request
> some part of the text to be visible; I don't know if AppKit uses it, or just
> follows the insertion point).
 
For the record, the parameter is kEventParamTextInputSendPinRng, and the landed patch doesn't use it.

 *          A TextRange record that specifies a start offset and an end
 *          offset that should be scrolled into view if the text
 *          specified by these offsets is not already in view. The
 *          fHiliteStyle field of the TextRange records is ignored in
 *          this parameter. This parameter is optional and may not be
 *          present in all instances of this event.

[Oliver Hunt]

Unfortunately we don't get raw carbon events, so there's not a whole lot we can do...

[Darin Adler]

(In reply to comment #5)
> (In reply to comment #0)
> > (there's a special Carbon Event parameter that an IM can pass to request
> > some part of the text to be visible; I don't know if AppKit uses it, or just
> > follows the insertion point).
> 
> For the record, the parameter is kEventParamTextInputSendPinRng, and the landed
> patch doesn't use it.

If we find that this is passed through AppKit in some form, we could some day change our code to base the scrolling on this instead of scrolling every time. For now I think we're OK.