Bug 14902 - Fix build for JavaScriptCore with qt4
Summary: Fix build for JavaScriptCore with qt4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-08 05:38 PDT by Paul Nasrat
Modified: 2007-08-08 09:33 PDT (History)
0 users

See Also:


Attachments
Change Unicode::toUpper declaration (593 bytes, patch)
2007-08-08 05:39 PDT, Paul Nasrat
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Nasrat 2007-08-08 05:38:03 PDT
Changeset 24919 broke building with qt4

../../../JavaScriptCore/kjs/string_object.cpp:725: error: invalid conversion from ‘const UChar*’ to ‘UChar*’
../../../JavaScriptCore/kjs/string_object.cpp:725: error:   initializing argument 3 of ‘int WTF::Unicode::toUpper(UChar*, int, UChar*, int, bool*)’
../../../JavaScriptCore/kjs/string_object.cpp:728: error: invalid conversion from ‘const UChar*’ to ‘UChar*’
Comment 1 Paul Nasrat 2007-08-08 05:39:54 PDT
Created attachment 15866 [details]
Change Unicode::toUpper declaration

This patch makes the qt4 Unicode::toUpper declaration take a const UChar* to mirror toLower.
Comment 2 Geoffrey Garen 2007-08-08 08:41:48 PDT
Comment on attachment 15866 [details]
Change Unicode::toUpper declaration

r=me
Comment 3 George Staikos 2007-08-08 09:33:03 PDT
Best to file Qt bugs in the qt component next time so I see them.  I already have a fix for this (identical).