Bug 14891 - Decompilation of try block immediately following "else" fails
Summary: Decompilation of try block immediately following "else" fails
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 13638
  Show dependency treegraph
 
Reported: 2007-08-06 14:48 PDT by Oliver Hunt
Modified: 2007-08-07 22:36 PDT (History)
2 users (show)

See Also:


Attachments
patch (3.42 KB, patch)
2007-08-06 23:05 PDT, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2007-08-06 14:48:26 PDT
Decompilation of function(){if (y) {} else try {} finally {}} incorrectly deompiles to
if (y) 
  {
  }
elsetry
  {
  }
  finally 
  {
  }

Notice the absence of whitespace between else and try.
Comment 1 Sam Weinig 2007-08-06 23:05:40 PDT
Created attachment 15855 [details]
patch
Comment 2 Oliver Hunt 2007-08-06 23:09:01 PDT
Comment on attachment 15855 [details]
patch

r=め!
Comment 3 Sam Weinig 2007-08-06 23:17:26 PDT
<rdar://problem/5391038>
Comment 4 Adam Roben (:aroben) 2007-08-06 23:24:12 PDT
Comment on attachment 15855 [details]
patch

+        (TryNode::streamTo): Add newline before else.

Looks to me like you added a newline before "try"
Comment 5 Sam Weinig 2007-08-06 23:26:50 PDT
Landed in r24904.