Bug 14882 – REGRESSION (r24866): text/plain documents are always downloaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[David Kilzer (:ddkilzer)]

* SUMMARY
Clicking on a link that returns a text/plain document is always downloaded.  There is no way to view it in the browser.

* STEPS TO REPRODUCE
1. Launch Safari/WebKit.
2. Click on a text/plain link.

* EXPECTED RESULTS
The text/plain document should be viewed within the browser.

* ACTUAL RESULTS
The text/plain document is always downloaded.

* REGRESSION
This is a regression from shipping Safari 2.0.4 (419.3) with original WebKit, as well as the Safari 3 Public Beta v. 3.0.3 (522.12.1).

* NOTES
Probably regressed in r24866, the fix for Bug 14824.

[David Kilzer (:ddkilzer)]

Created attachment 15839 [details]
Test case

[David Kilzer (:ddkilzer)]

<rdar://problem/5386550>

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> * NOTES
> Probably regressed in r24866, the fix for Bug 14824.

Confirmed.

[David Kilzer (:ddkilzer)]

I have a patch for this.

[David Kilzer (:ddkilzer)]

Created attachment 15842 [details]
Patch v1

Proposed fix.

[David Kilzer (:ddkilzer)]

Fixed in r24869.  Thanks for the review olliej!

[Brady Eidson]

This rebroke http://bugs.webkit.org/show_bug.cgi?id=14824

Granted, I did screw up the original fix, but this isn't the right fix - I'll explore the reasons why in http://bugs.webkit.org/show_bug.cgi?id=14824

[James Wheare]

This is still broken in Safari 3.0.4 (5523.10) in certain cases . Here are the response headers for a file that still gets downloaded (Note: document served with HTTP Basic authentication)

HTTP/1.1 200 OK
Wed, 21 Nov 2007 11:08:50 GMT
Apache/1.3.31 (Unix) PHP/4.4.3
PHP/4.4.3
gzip
Accept-Encoding
close
chunked
text/plain;charset=utf-8

[James Wheare]

Possibly related to http://bugs.webkit.org/show_bug.cgi?id=15771

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> This is still broken in Safari 3.0.4 (5523.10) in certain cases . Here are the
> response headers for a file that still gets downloaded (Note: document served
> with HTTP Basic authentication)
> 
> HTTP/1.1 200 OK
> Wed, 21 Nov 2007 11:08:50 GMT
> Apache/1.3.31 (Unix) PHP/4.4.3
> PHP/4.4.3
> gzip
> Accept-Encoding
> close
> chunked
> text/plain;charset=utf-8

Hi James, please open a new bug report for this issue.  Also, please include the header names with the field values above, and please state whether you're using Tiger or Leopard.  Thanks!

[James Wheare]

http://bugs.webkit.org/show_bug.cgi?id=16084