Bug 14866 - [S60] Widget Cascade menu not in FIFO order
Summary: [S60] Widget Cascade menu not in FIFO order
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 417.x
Hardware: S60 Emulator S60 3rd edition
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-02 16:59 PDT by Sriram
Modified: 2008-04-09 11:39 PDT (History)
0 users

See Also:

Attachments
Patch for 3.1 (18.12 KB, patch)
2007-08-02 17:12 PDT, Sriram 		zalan: review+
Details | Formatted Diff | Diff
Patch for 3.2 (3.70 KB, patch)
2007-08-02 17:34 PDT, Sriram 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram 2007-08-02 16:59:28 PDT 
SYAI-73AS6K
Comment 1 Sriram 2007-08-02 17:12:35 PDT 
Created attachment 15811 [details]
Patch for 3.1
Comment 2 Sriram 2007-08-02 17:34:36 PDT 
Created attachment 15812 [details]
Patch for 3.2
Comment 3 Sornalatha Rathnasamy 2007-08-03 07:18:45 PDT 
TInt index = aIsRootMenuPane ? aMenuPane.NumberOfItemsInPane() - 1 : aMenuPane.NumberOfItemsInPane();

------------------

this piece of code assumes that if aIsRootMenuPane is true, NumberOfItemsInPane will always be greater than 0. But we should still handle the case : if inadvertently the value is 0, it would crash since aMenuPane.NumberOfItemsInPane() - 1  will evaluate to -1.
Comment 4 Sriram 2007-08-03 07:25:05 PDT 
Agreed.
aMenuPane.NumberOfItemsInPane() - 1 should be
Max(aMenuPane.NumberOfItemsInPane() - 1,0)

Any other comments?
Comment 5 zalan 2007-08-03 10:07:22 PDT 
Comment on attachment 15811 [details]
Patch for 3.1

r=me
Comment 6 zalan 2007-08-03 10:07:43 PDT 
Comment on attachment 15812 [details]
Patch for 3.2

r=me
Comment 7 zalan 2007-08-03 10:24:08 PDT 
3.1->24845
ccb->24846
Comment 8 Bradley Morrison 2008-04-09 11:39:39 PDT 
Bulk closing of all s60 platform bugs. 

Sorry for the noise!