CLOSED FIXED 14866
[S60] Widget Cascade menu not in FIFO order 
https://bugs.webkit.org/show_bug.cgi?id=14866
Summary [S60] Widget Cascade menu not in FIFO order
Sriram
Reported 2007-08-02 16:59:28 PDT
SYAI-73AS6K
Attachments
Patch for 3.1 (18.12 KB, patch)
2007-08-02 17:12 PDT, Sriram 		zalan: review+
DetailsFormatted DiffDiff
Patch for 3.2 (3.70 KB, patch)
2007-08-02 17:34 PDT, Sriram 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sriram
Comment 1 2007-08-02 17:12:35 PDT
Created attachment 15811 [details] Patch for 3.1
Sriram
Comment 2 2007-08-02 17:34:36 PDT
Created attachment 15812 [details] Patch for 3.2
Sornalatha Rathnasamy
Comment 3 2007-08-03 07:18:45 PDT
TInt index = aIsRootMenuPane ? aMenuPane.NumberOfItemsInPane() - 1 : aMenuPane.NumberOfItemsInPane(); ------------------ this piece of code assumes that if aIsRootMenuPane is true, NumberOfItemsInPane will always be greater than 0. But we should still handle the case : if inadvertently the value is 0, it would crash since aMenuPane.NumberOfItemsInPane() - 1 will evaluate to -1.
Sriram
Comment 4 2007-08-03 07:25:05 PDT
Agreed. aMenuPane.NumberOfItemsInPane() - 1 should be Max(aMenuPane.NumberOfItemsInPane() - 1,0) Any other comments?
zalan
Comment 5 2007-08-03 10:07:22 PDT
Comment on attachment 15811 [details] Patch for 3.1 r=me
zalan
Comment 6 2007-08-03 10:07:43 PDT
Comment on attachment 15812 [details] Patch for 3.2 r=me
zalan
Comment 7 2007-08-03 10:24:08 PDT
3.1->24845 ccb->24846
Bradley Morrison
Comment 8 2008-04-09 11:39:39 PDT
Bulk closing of all s60 platform bugs. Sorry for the noise!
Note You need to log in before you can comment on or make changes to this bug.